From: Dan Carpenter <dan.carpenter@oracle.com>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] ide: replace GFP_ATOMIC by GFP_KERNEL
Date: Thu, 09 Apr 2015 12:36:33 +0000 [thread overview]
Message-ID: <20150409123633.GN10964@mwanda> (raw)
In-Reply-To: <1428579988-10167-3-git-send-email-lambert.quentin@gmail.com>
On Thu, Apr 09, 2015 at 01:46:28PM +0200, Quentin Lambert wrote:
> Both pmac_ide_init_dma and ide_dma_sgiioc4 are stored in the init_dma field of
> an ide_port_info structure. This field seems to only be called from contexts
> where sleep is allowed. Therefore, this patch replaces uses of GFP_ATOMIC by
> GFP_KERNEL.
>
> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Oh. They're not GFP_ATOMIC.
Fold these two patches together into one patch and resend.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/2] ide: replace GFP_ATOMIC by GFP_KERNEL
Date: Thu, 9 Apr 2015 15:36:33 +0300 [thread overview]
Message-ID: <20150409123633.GN10964@mwanda> (raw)
In-Reply-To: <1428579988-10167-3-git-send-email-lambert.quentin@gmail.com>
On Thu, Apr 09, 2015 at 01:46:28PM +0200, Quentin Lambert wrote:
> Both pmac_ide_init_dma and ide_dma_sgiioc4 are stored in the init_dma field of
> an ide_port_info structure. This field seems to only be called from contexts
> where sleep is allowed. Therefore, this patch replaces uses of GFP_ATOMIC by
> GFP_KERNEL.
>
> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Oh. They're not GFP_ATOMIC.
Fold these two patches together into one patch and resend.
regards,
dan carpenter
next prev parent reply other threads:[~2015-04-09 12:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 11:46 [PATCH 0/2] pci to dma Quentin Lambert
2015-04-09 11:46 ` Quentin Lambert
2015-04-09 11:46 ` [PATCH 1/2] ide: remove deprecated use of pci api Quentin Lambert
2015-04-09 11:46 ` Quentin Lambert
2015-04-09 12:35 ` Dan Carpenter
2015-04-09 12:35 ` Dan Carpenter
2015-04-13 12:25 ` One Thousand Gnomes
2015-04-13 12:25 ` One Thousand Gnomes
2015-04-13 17:08 ` David Miller
2015-04-13 17:08 ` David Miller
2015-04-13 17:23 ` Dan Carpenter
2015-04-13 17:23 ` Dan Carpenter
2015-04-13 17:39 ` David Miller
2015-04-13 17:39 ` David Miller
2015-04-09 11:46 ` [PATCH 2/2] ide: replace GFP_ATOMIC by GFP_KERNEL Quentin Lambert
2015-04-09 11:46 ` Quentin Lambert
2015-04-09 12:36 ` Dan Carpenter [this message]
2015-04-09 12:36 ` Dan Carpenter
2015-04-09 14:33 ` Quentin Lambert
2015-04-09 14:33 ` Quentin Lambert
2015-04-09 14:40 ` Dan Carpenter
2015-04-09 14:40 ` Dan Carpenter
2015-04-09 14:50 ` Dan Carpenter
2015-04-09 14:50 ` Dan Carpenter
2015-04-09 14:51 ` Quentin Lambert
2015-04-09 14:51 ` Quentin Lambert
2015-04-09 14:53 ` Julia Lawall
2015-04-09 14:53 ` Julia Lawall
2015-04-09 15:13 ` Dan Carpenter
2015-04-09 15:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150409123633.GN10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=lambert.quentin@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.