All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
	Mike Turquette <mturquette@linaro.org>,
	kernel-janitors@vger.kernel.org, linux-clk@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] clk: versatile: test returned value
Date: Thu, 09 Apr 2015 15:23:38 +0000	[thread overview]
Message-ID: <20150409152338.GA18835@codeaurora.org> (raw)
In-Reply-To: <CACRpkdYU+hN6gEtVzwahGz+B07dqrDzQkTZz2xikGH0dMdYX1Q@mail.gmail.com>

On 04/09, Linus Walleij wrote:
> On Sat, Apr 4, 2015 at 4:59 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> 
> > Put NULL test on the result of the previous call instead on one of its
> > arguments.  A simplified version of the semantic match that finds this
> > problem is as follows (http://coccinelle.lip6.fr/):
> >
> > // <smpl>
> > r@
> > expression *e1;
> > expression *e2;
> > identifier f;
> > statement S1,S2;
> > @@
> >
> > e1 = f(...,e2,...);
> > (
> > if (e1 = NULL || ...) S1 else S2
> > |
> > *if (e2 = NULL || ...) S1 else S2
> > )
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Yep that's a bug:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 

Thanks. Applied to clk-next.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Julia Lawall <Julia.Lawall@lip6.fr>,
	Mike Turquette <mturquette@linaro.org>,
	kernel-janitors@vger.kernel.org, linux-clk@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] clk: versatile: test returned value
Date: Thu, 9 Apr 2015 08:23:38 -0700	[thread overview]
Message-ID: <20150409152338.GA18835@codeaurora.org> (raw)
In-Reply-To: <CACRpkdYU+hN6gEtVzwahGz+B07dqrDzQkTZz2xikGH0dMdYX1Q@mail.gmail.com>

On 04/09, Linus Walleij wrote:
> On Sat, Apr 4, 2015 at 4:59 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote:
> 
> > Put NULL test on the result of the previous call instead on one of its
> > arguments.  A simplified version of the semantic match that finds this
> > problem is as follows (http://coccinelle.lip6.fr/):
> >
> > // <smpl>
> > r@
> > expression *e1;
> > expression *e2;
> > identifier f;
> > statement S1,S2;
> > @@
> >
> > e1 = f(...,e2,...);
> > (
> > if (e1 == NULL || ...) S1 else S2
> > |
> > *if (e2 == NULL || ...) S1 else S2
> > )
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> Yep that's a bug:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 

Thanks. Applied to clk-next.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

  reply	other threads:[~2015-04-09 15:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-04 14:59 [PATCH 0/2] test returned value Julia Lawall
2015-04-04 14:59 ` Julia Lawall
2015-04-04 14:59 ` [PATCH 1/2] clk: versatile: " Julia Lawall
2015-04-04 14:59   ` Julia Lawall
2015-04-08 18:25   ` Stephen Boyd
2015-04-08 18:25     ` Stephen Boyd
2015-04-09  7:30   ` Linus Walleij
2015-04-09  7:30     ` Linus Walleij
2015-04-09 15:23     ` Stephen Boyd [this message]
2015-04-09 15:23       ` Stephen Boyd
2015-04-04 14:59 ` [PATCH 2/2] staging: emxx_udc: " Julia Lawall
2015-04-04 14:59   ` Julia Lawall
2015-04-04 15:59   ` Dan Carpenter
2015-04-04 15:59     ` Dan Carpenter
2015-04-04 16:07     ` Greg Kroah-Hartman
2015-04-04 16:07       ` Greg Kroah-Hartman
2015-04-04 16:07   ` Greg Kroah-Hartman
2015-04-04 16:07     ` Greg Kroah-Hartman
2015-04-04 16:20     ` Julia Lawall
2015-04-04 16:20       ` Julia Lawall
2015-04-04 16:54       ` Greg Kroah-Hartman
2015-04-04 16:54         ` Greg Kroah-Hartman
2015-04-04 17:12       ` Dan Carpenter
2015-04-04 17:12         ` Dan Carpenter
2015-04-04 17:21         ` Julia Lawall
2015-04-04 17:21           ` Julia Lawall
2015-04-04 17:31           ` Dan Carpenter
2015-04-04 17:31             ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150409152338.GA18835@codeaurora.org \
    --to=sboyd@codeaurora.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.