From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] crypto: add new driver for Marvell CESA
Date: Thu, 9 Apr 2015 17:37:27 +0200 [thread overview]
Message-ID: <20150409153727.GF1459@lunn.ch> (raw)
In-Reply-To: <20150409172826.18916274@bbrezillon>
On Thu, Apr 09, 2015 at 05:28:26PM +0200, Boris Brezillon wrote:
> Hi Andrew,
>
> On Thu, 9 Apr 2015 17:18:46 +0200
> Andrew Lunn <andrew@lunn.ch> wrote:
>
> > On Thu, Apr 09, 2015 at 04:58:41PM +0200, Boris Brezillon wrote:
> > > Hello,
> > >
> > > This is an attempt to replace the mv_cesa driver by a new one to address
> > > some limitations of the existing driver.
> > > >From a performance and CPU load point of view the most important
> > > limitation is the lack of DMA support, thus preventing us from chaining
> > > crypto operations.
> > >
> > > I know we usually try to adapt existing drivers instead of replacing them
> > > by new ones, but after trying to refactor the mv_cesa driver I realized it
> > > would take longer than writing an new one from scratch.
> >
> > Hi Boris
> >
> > What is the situation with backwards compatibility? I see you have
> > kept the old compatibility string, and added lots of new ones, and
> > deprecated some properties. Will an old DT blob still work?
>
> Yep, I tried on an Orion platform, and Arnaud tried on a Kirkwood one
> without any changes to the existing DT and it works.
Great. It would be nice to state this in the ChangeLog or cover note.
> Anyway, IMHO even those DT should be updated to use the new bindings
> (sram nodes, new compatible if available, addition of clock-names
> properties, ...).
Agreed. Maybe you can extend the patchset to modify the relevant .dtsi
files?
Thanks
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> (by way of Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>)
To: Boris Brezillon
<boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH 0/2] crypto: add new driver for Marvell CESA
Date: Thu, 9 Apr 2015 17:37:27 +0200 [thread overview]
Message-ID: <20150409153727.GF1459@lunn.ch> (raw)
In-Reply-To: <20150409172826.18916274@bbrezillon>
On Thu, Apr 09, 2015 at 05:28:26PM +0200, Boris Brezillon wrote:
> Hi Andrew,
>
> On Thu, 9 Apr 2015 17:18:46 +0200
> Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> wrote:
>
> > On Thu, Apr 09, 2015 at 04:58:41PM +0200, Boris Brezillon wrote:
> > > Hello,
> > >
> > > This is an attempt to replace the mv_cesa driver by a new one to address
> > > some limitations of the existing driver.
> > > >From a performance and CPU load point of view the most important
> > > limitation is the lack of DMA support, thus preventing us from chaining
> > > crypto operations.
> > >
> > > I know we usually try to adapt existing drivers instead of replacing them
> > > by new ones, but after trying to refactor the mv_cesa driver I realized it
> > > would take longer than writing an new one from scratch.
> >
> > Hi Boris
> >
> > What is the situation with backwards compatibility? I see you have
> > kept the old compatibility string, and added lots of new ones, and
> > deprecated some properties. Will an old DT blob still work?
>
> Yep, I tried on an Orion platform, and Arnaud tried on a Kirkwood one
> without any changes to the existing DT and it works.
Great. It would be nice to state this in the ChangeLog or cover note.
> Anyway, IMHO even those DT should be updated to use the new bindings
> (sram nodes, new compatible if available, addition of clock-names
> properties, ...).
Agreed. Maybe you can extend the patchset to modify the relevant .dtsi
files?
Thanks
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch> (by way of Boris Brezillon <boris.brezillon@free-electrons.com>)
To: Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: Re: [PATCH 0/2] crypto: add new driver for Marvell CESA
Date: Thu, 9 Apr 2015 17:37:27 +0200 [thread overview]
Message-ID: <20150409153727.GF1459@lunn.ch> (raw)
In-Reply-To: <20150409172826.18916274@bbrezillon>
On Thu, Apr 09, 2015 at 05:28:26PM +0200, Boris Brezillon wrote:
> Hi Andrew,
>
> On Thu, 9 Apr 2015 17:18:46 +0200
> Andrew Lunn <andrew@lunn.ch> wrote:
>
> > On Thu, Apr 09, 2015 at 04:58:41PM +0200, Boris Brezillon wrote:
> > > Hello,
> > >
> > > This is an attempt to replace the mv_cesa driver by a new one to address
> > > some limitations of the existing driver.
> > > >From a performance and CPU load point of view the most important
> > > limitation is the lack of DMA support, thus preventing us from chaining
> > > crypto operations.
> > >
> > > I know we usually try to adapt existing drivers instead of replacing them
> > > by new ones, but after trying to refactor the mv_cesa driver I realized it
> > > would take longer than writing an new one from scratch.
> >
> > Hi Boris
> >
> > What is the situation with backwards compatibility? I see you have
> > kept the old compatibility string, and added lots of new ones, and
> > deprecated some properties. Will an old DT blob still work?
>
> Yep, I tried on an Orion platform, and Arnaud tried on a Kirkwood one
> without any changes to the existing DT and it works.
Great. It would be nice to state this in the ChangeLog or cover note.
> Anyway, IMHO even those DT should be updated to use the new bindings
> (sram nodes, new compatible if available, addition of clock-names
> properties, ...).
Agreed. Maybe you can extend the patchset to modify the relevant .dtsi
files?
Thanks
Andrew
next prev parent reply other threads:[~2015-04-09 15:37 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 14:58 [PATCH 0/2] crypto: add new driver for Marvell CESA Boris Brezillon
2015-04-09 14:58 ` Boris Brezillon
2015-04-09 14:58 ` [PATCH 1/2] " Boris Brezillon
[not found] ` <1428591523-1780-2-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2015-04-10 10:38 ` Paul Bolle
2015-04-10 10:38 ` Paul Bolle
2015-04-10 10:38 ` Paul Bolle
2015-04-10 11:17 ` Boris Brezillon
2015-04-10 11:17 ` Boris Brezillon
2015-04-09 14:58 ` [PATCH 2/2] crypto: marvell/CESA: update DT bindings documentation Boris Brezillon
2015-04-09 14:58 ` Boris Brezillon
2015-04-09 15:18 ` [PATCH 0/2] crypto: add new driver for Marvell CESA Andrew Lunn
2015-04-09 15:18 ` Andrew Lunn
[not found] ` <20150409172826.18916274@bbrezillon>
2015-04-09 15:37 ` Andrew Lunn [this message]
2015-04-09 15:37 ` Andrew Lunn
2015-04-09 15:37 ` Andrew Lunn
2015-04-09 15:37 ` Andrew Lunn
2015-04-09 15:34 ` Sebastian Hesselbarth
2015-04-09 15:34 ` Sebastian Hesselbarth
2015-04-09 15:57 ` Boris Brezillon
2015-04-09 15:57 ` Boris Brezillon
2015-04-09 23:21 ` Arnaud Ebalard
2015-04-09 23:21 ` Arnaud Ebalard
2015-04-09 23:21 ` Arnaud Ebalard
2015-04-09 15:52 ` Stephan Mueller
2015-04-09 15:52 ` Stephan Mueller
2015-04-10 13:50 ` Jason Cooper
2015-04-10 13:50 ` Jason Cooper
2015-04-10 15:11 ` Boris Brezillon
2015-04-10 15:11 ` Boris Brezillon
2015-04-10 22:30 ` Jason Cooper
2015-04-10 22:30 ` Jason Cooper
2015-04-13 9:39 ` Gregory CLEMENT
2015-04-13 9:39 ` Gregory CLEMENT
2015-04-13 12:47 ` Jason Cooper
2015-04-13 12:47 ` Jason Cooper
2015-04-13 16:06 ` Arnaud Ebalard
2015-04-13 16:06 ` Arnaud Ebalard
2015-04-13 20:11 ` Jason Cooper
2015-04-13 20:11 ` Jason Cooper
2015-04-17 8:33 ` Boris Brezillon
2015-04-17 8:33 ` Boris Brezillon
2015-04-17 8:39 ` Boris Brezillon
2015-04-17 8:39 ` Boris Brezillon
2015-04-17 10:59 ` Jason Cooper
2015-04-17 10:59 ` Jason Cooper
2015-04-17 13:01 ` Gregory CLEMENT
2015-04-17 13:01 ` Gregory CLEMENT
2015-04-17 14:19 ` Boris Brezillon
2015-04-17 14:19 ` Boris Brezillon
2015-04-17 14:32 ` Maxime Ripard
2015-04-17 14:32 ` Maxime Ripard
2015-04-17 14:40 ` Gregory CLEMENT
2015-04-17 14:40 ` Gregory CLEMENT
2015-04-17 14:50 ` Maxime Ripard
2015-04-17 14:50 ` Maxime Ripard
2015-04-17 15:01 ` Gregory CLEMENT
2015-04-17 15:01 ` Gregory CLEMENT
2015-04-17 15:01 ` Gregory CLEMENT
2015-04-17 15:49 ` Maxime Ripard
2015-04-17 15:49 ` Maxime Ripard
2015-04-17 16:04 ` Gregory CLEMENT
2015-04-17 16:04 ` Gregory CLEMENT
2015-04-17 16:04 ` Gregory CLEMENT
2015-04-28 19:52 ` Boris Brezillon
2015-04-28 19:52 ` Boris Brezillon
2015-04-29 9:49 ` Herbert Xu
2015-04-29 9:49 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150409153727.GF1459@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.