From: Florian Westphal <fw@strlen.de>
To: David Miller <davem@davemloft.net>
Cc: eric.dumazet@gmail.com, sebastian.poehn@gmail.com,
netdev@vger.kernel.org
Subject: Re: [FYI] xfrm: Don't lookup sk_policy for timewait sockets
Date: Thu, 9 Apr 2015 21:14:41 +0200 [thread overview]
Message-ID: <20150409191441.GE20653@breakpoint.cc> (raw)
In-Reply-To: <20150409.143727.1391401196320839634.davem@davemloft.net>
David Miller <davem@davemloft.net> wrote:
> From: Eric Dumazet <eric.dumazet@gmail.com>
> Date: Thu, 09 Apr 2015 02:07:41 -0700
>
> > TCP stack never sends packets attached to a socket in timewait state.
>
> TPROXY assigns timewait sockets to skb->sk, that's the bug.
I re-introduced this in fd158d79d33d3c under the assumption
that the input path handles skb->sk timewait sockets correctly
after all the early demux changes, afaics tcp edemux can also
assign skb->sk timewait sockets.
Also, reporter mentions 3.8 as affected which should not assign
tw sockets to skb->sk.
Even more strange, the reporters backtrace seems to indicate
crash at end of forward path.
Sebastian, can you disable tw assignment via TPROXY in 3.12 just
to see if it makes a difference?
[ not doing the assignment is safe provided you still set tproxy mark
on the skb; policy routing will ensure local delivery ].
next prev parent reply other threads:[~2015-04-09 19:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 8:09 [FYI] xfrm: Don't lookup sk_policy for timewait sockets Sebastian Poehn
2015-04-09 9:07 ` Eric Dumazet
2015-04-09 9:24 ` Sebastian Poehn
2015-04-09 18:37 ` David Miller
2015-04-09 19:14 ` Florian Westphal [this message]
2015-04-09 21:07 ` David Miller
2015-04-09 21:21 ` Florian Westphal
2015-04-10 11:14 ` Sebastian Poehn
2015-04-13 8:04 ` Sebastian Poehn
2015-04-13 15:09 ` Sebastian Poehn
2015-04-13 15:39 ` Eric Dumazet
2015-04-13 17:25 ` David Miller
2015-04-13 16:04 ` Florian Westphal
2015-04-09 19:21 ` Eric Dumazet
2015-04-09 19:25 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150409191441.GE20653@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.poehn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.