All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Boqun Feng <boqun.feng@linux.vnet.ibm.com>,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
	Anton Blanchard <anton@samba.org>,
	Brice Goglin <Brice.Goglin@inria.fr>,
	linuxppc-dev@lists.ozlabs.org,
	Anshuman Khandual <khandual@linux.vnet.ibm.com>
Subject: Re: Topology updates and NUMA-level sched domains
Date: Thu, 9 Apr 2015 15:40:40 -0700	[thread overview]
Message-ID: <20150409224040.GG53918@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150408105212.GP21418@twins.programming.kicks-ass.net>

On 08.04.2015 [12:52:12 +0200], Peter Zijlstra wrote:
> On Wed, Apr 08, 2015 at 12:32:01PM +0200, Brice Goglin wrote:
> > Le 07/04/2015 21:41, Peter Zijlstra a écrit :
> > > No, that's very much not the same. Even if it were dealing with hotplug
> > > it would still assume the cpu to return to the same node.
> > >
> > > But mostly people do not even bother to handle hotplug.
> > >
> > 
> > You said userspace assumes the cpu<->node relation is a boot-time fixed
> > one, and hotplug breaks this.
> 
> I said no such thing. Regular hotplug actually respects that relation.

Wel, sort of. If you *just* hotplug a CPU out, your invariant of what
CPUs are currently available on what nodes is no longer held. Similarly
if you just add a CPU. And means that you could end up using cpumasks
that are incorrect if you don't make them at runtime, it seems?

> > How do you expect userspace to handle hotplug?
> 
> Mostly not. Why would they? CPU hotplug is rare and mostly a case of:
> don't do that then.
> 
> Its just that some of the virt wankers are using it for resource
> management which is entirely misguided. Then again, most of virt is.

I guess that is a matter of opinion.

-Nish

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Brice Goglin <Brice.Goglin@inria.fr>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org,
	Srikar Dronamraju <srikar@linux.vnet.ibm.com>,
	Boqun Feng <boqun.feng@linux.vnet.ibm.com>,
	Anshuman Khandual <khandual@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Anton Blanchard <anton@samba.org>
Subject: Re: Topology updates and NUMA-level sched domains
Date: Thu, 9 Apr 2015 15:40:40 -0700	[thread overview]
Message-ID: <20150409224040.GG53918@linux.vnet.ibm.com> (raw)
In-Reply-To: <20150408105212.GP21418@twins.programming.kicks-ass.net>

On 08.04.2015 [12:52:12 +0200], Peter Zijlstra wrote:
> On Wed, Apr 08, 2015 at 12:32:01PM +0200, Brice Goglin wrote:
> > Le 07/04/2015 21:41, Peter Zijlstra a écrit :
> > > No, that's very much not the same. Even if it were dealing with hotplug
> > > it would still assume the cpu to return to the same node.
> > >
> > > But mostly people do not even bother to handle hotplug.
> > >
> > 
> > You said userspace assumes the cpu<->node relation is a boot-time fixed
> > one, and hotplug breaks this.
> 
> I said no such thing. Regular hotplug actually respects that relation.

Wel, sort of. If you *just* hotplug a CPU out, your invariant of what
CPUs are currently available on what nodes is no longer held. Similarly
if you just add a CPU. And means that you could end up using cpumasks
that are incorrect if you don't make them at runtime, it seems?

> > How do you expect userspace to handle hotplug?
> 
> Mostly not. Why would they? CPU hotplug is rare and mostly a case of:
> don't do that then.
> 
> Its just that some of the virt wankers are using it for resource
> management which is entirely misguided. Then again, most of virt is.

I guess that is a matter of opinion.

-Nish


  reply	other threads:[~2015-04-09 22:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-06 21:45 Topology updates and NUMA-level sched domains Nishanth Aravamudan
2015-04-06 21:45 ` Nishanth Aravamudan
2015-04-07 10:21 ` Peter Zijlstra
2015-04-07 10:21   ` Peter Zijlstra
2015-04-07 17:14   ` Nishanth Aravamudan
2015-04-07 17:14     ` Nishanth Aravamudan
2015-04-07 19:41     ` Peter Zijlstra
2015-04-07 19:41       ` Peter Zijlstra
2015-04-08 10:32       ` Brice Goglin
2015-04-08 10:32         ` Brice Goglin
2015-04-08 10:52         ` Peter Zijlstra
2015-04-08 10:52           ` Peter Zijlstra
2015-04-09 22:40           ` Nishanth Aravamudan [this message]
2015-04-09 22:40             ` Nishanth Aravamudan
2015-04-09 22:37         ` Nishanth Aravamudan
2015-04-09 22:37           ` Nishanth Aravamudan
2015-04-09 22:29       ` Nishanth Aravamudan
2015-04-09 22:29         ` Nishanth Aravamudan
2015-04-10  8:31         ` Peter Zijlstra
2015-04-10  8:31           ` Peter Zijlstra
2015-04-10  9:08           ` Peter Zijlstra
2015-04-10  9:08             ` Peter Zijlstra
2015-04-10 19:50             ` Nishanth Aravamudan
2015-04-10 19:50               ` Nishanth Aravamudan
2015-04-10 20:30           ` Nishanth Aravamudan
2015-04-10 20:30             ` Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150409224040.GG53918@linux.vnet.ibm.com \
    --to=nacc@linux.vnet.ibm.com \
    --cc=Brice.Goglin@inria.fr \
    --cc=anton@samba.org \
    --cc=boqun.feng@linux.vnet.ibm.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=srikar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.