From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Radim Krcmar <rkrcmar@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
devel@linuxdriverproject.org
Subject: Re: [PATCH v3 03/21] Drivers: hv: kvp: move poll_channel() to hyperv_vmbus.h
Date: Fri, 10 Apr 2015 21:27:42 +0300 [thread overview]
Message-ID: <20150410182742.GQ10964@mwanda> (raw)
In-Reply-To: <1428568730-6030-4-git-send-email-vkuznets@redhat.com>
On Thu, Apr 09, 2015 at 10:38:32AM +0200, Vitaly Kuznetsov wrote:
> ..., make it inline and rename it to hv_poll_channel() so it can be reused
> in other hv_util modules.
>
The "...," is fine in the git log but I noticed recently that if you're
reading patches in a web archive then often the subject and the body are
several lines apart.
http://marc.info/?l=linux-api&m=142856917031730&w=2
It's awkward to follow.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
devel@linuxdriverproject.org, Radim Krcmar <rkrcmar@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Haiyang Zhang <haiyangz@microsoft.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [PATCH v3 03/21] Drivers: hv: kvp: move poll_channel() to hyperv_vmbus.h
Date: Fri, 10 Apr 2015 21:27:42 +0300 [thread overview]
Message-ID: <20150410182742.GQ10964@mwanda> (raw)
In-Reply-To: <1428568730-6030-4-git-send-email-vkuznets@redhat.com>
On Thu, Apr 09, 2015 at 10:38:32AM +0200, Vitaly Kuznetsov wrote:
> ..., make it inline and rename it to hv_poll_channel() so it can be reused
> in other hv_util modules.
>
The "...," is fine in the git log but I noticed recently that if you're
reading patches in a web archive then often the subject and the body are
several lines apart.
http://marc.info/?l=linux-api&m=142856917031730&w=2
It's awkward to follow.
regards,
dan carpenter
next prev parent reply other threads:[~2015-04-10 18:27 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 8:38 [PATCH v3 00/21] Drivers: hv: utils: re-implement the kernel/userspace communication layer Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 01/21] Drivers: hv: util: move kvp/vss function declarations to hyperv_vmbus.h Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 02/21] Drivers: hv: kvp: reset kvp_context Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 03/21] Drivers: hv: kvp: move poll_channel() to hyperv_vmbus.h Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-10 18:27 ` Dan Carpenter [this message]
2015-04-10 18:27 ` Dan Carpenter
2015-04-13 8:36 ` Vitaly Kuznetsov
2015-04-13 8:36 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 04/21] Drivers: hv: fcopy: process deferred messages when we complete the transaction Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 05/21] Drivers: hv: vss: " Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 07/21] Drivers: hv: fcopy: rename fcopy_work -> fcopy_timeout_work Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 09/21] Drivers: hv: kvp: switch to using the hvutil_device_state state machine Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 10/21] Drivers: hv: vss: " Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 12/21] Drivers: hv: fcopy: set .owner reference for file operations Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 13/21] Drivers: hv: util: introduce hv_utils_transport abstraction Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 14/21] Drivers: hv: vss: convert to hv_utils_transport Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 15/21] Drivers: hv: fcopy: " Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 16/21] Drivers: hv: kvp: " Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 17/21] Tools: hv: kvp: use misc char device to communicate with kernel Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
[not found] ` <1428568730-6030-1-git-send-email-vkuznets-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-04-09 8:38 ` [PATCH v3 06/21] Drivers: hv: kvp: rename kvp_work -> kvp_timeout_work Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 08/21] Drivers: hv: util: introduce state machine for util drivers Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 11/21] Drivers: hv: fcopy: switch to using the hvutil_device_state state machine Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 18/21] Tools: hv: vss: use misc char device to communicate with kernel Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 20/21] Drivers: hv: fcopy: full handshake support Vitaly Kuznetsov
2015-04-09 8:38 ` Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 19/21] Drivers: hv: vss: " Vitaly Kuznetsov
2015-04-09 8:38 ` [PATCH v3 21/21] Drivers: hv: utils: unify driver registration reporting Vitaly Kuznetsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410182742.GQ10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.