From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: rtc-linux@googlegroups.com
Cc: Keerthy <a0393675@ti.com>,
Igor Grinberg <grinberg@compulab.co.il>,
Keerthy <j-keerthy@ti.com>,
a.zummo@towertech.it, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [rtc-linux] [PATCH] rtc: OMAP: Add external 32k clock feature
Date: Sat, 11 Apr 2015 00:23:55 +0200 [thread overview]
Message-ID: <20150410222355.GE20669@piout.net> (raw)
In-Reply-To: <20150410133730.8f84b2894efcf1bde075048f@linux-foundation.org>
On 10/04/2015 at 13:37:30 -0700, Andrew Morton wrote :
> Is there any way in which we can get all systems working properly? If
> there's no way of auto-detecting an external oscillator then perhaps a
> module parameter is needed. If so, it would be better if the driver
> were to default to internal oscillator (ie: current behaviour), and the
> module parameter selects the external oscillator. This way, existing
> systems are unaffected by the kernel upgrade.
>
Actually, I would use the common clock framework, allowing to chose
between the internal and an external clock source by using the "clocks"
property. This would also allow to have the correct reference count on
that 32k internal clock. It may not matter now but for example, not
doing so became a problem on at91.
As a fallback, if no clocks property is available, I would use the
internal 32k to keep DT ABI backward compatibility.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: rtc-linux@googlegroups.com
Cc: Keerthy <a0393675@ti.com>,
Igor Grinberg <grinberg@compulab.co.il>,
Keerthy <j-keerthy@ti.com>,
a.zummo@towertech.it, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [rtc-linux] [PATCH] rtc: OMAP: Add external 32k clock feature
Date: Sat, 11 Apr 2015 00:23:55 +0200 [thread overview]
Message-ID: <20150410222355.GE20669@piout.net> (raw)
In-Reply-To: <20150410133730.8f84b2894efcf1bde075048f@linux-foundation.org>
On 10/04/2015 at 13:37:30 -0700, Andrew Morton wrote :
> Is there any way in which we can get all systems working properly? If
> there's no way of auto-detecting an external oscillator then perhaps a
> module parameter is needed. If so, it would be better if the driver
> were to default to internal oscillator (ie: current behaviour), and the
> module parameter selects the external oscillator. This way, existing
> systems are unaffected by the kernel upgrade.
>
Actually, I would use the common clock framework, allowing to chose
between the internal and an external clock source by using the "clocks"
property. This would also allow to have the correct reference count on
that 32k internal clock. It may not matter now but for example, not
doing so became a problem on at91.
As a fallback, if no clocks property is available, I would use the
internal 32k to keep DT ABI backward compatibility.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
next prev parent reply other threads:[~2015-04-10 22:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 9:42 [PATCH] rtc: OMAP: Add external 32k clock feature Keerthy
2015-03-03 9:42 ` Keerthy
2015-03-17 4:15 ` Keerthy
2015-03-17 4:15 ` Keerthy
2015-03-24 22:59 ` [rtc-linux] " Andrew Morton
2015-03-24 22:59 ` Andrew Morton
2015-04-07 3:29 ` Keerthy
2015-04-07 3:29 ` Keerthy
2015-04-07 3:29 ` Keerthy
2015-04-07 7:06 ` Igor Grinberg
2015-04-07 7:06 ` Igor Grinberg
2015-04-10 8:26 ` Keerthy
2015-04-10 8:26 ` Keerthy
2015-04-10 8:26 ` Keerthy
2015-04-10 20:37 ` Andrew Morton
2015-04-10 20:37 ` Andrew Morton
2015-04-10 20:37 ` Andrew Morton
2015-04-10 22:23 ` Alexandre Belloni [this message]
2015-04-10 22:23 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150410222355.GE20669@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=a0393675@ti.com \
--cc=grinberg@compulab.co.il \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.