All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Michael Halcrow <mhalcrow@google.com>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4 crypto: fix an error code in ext4_init_crypto()
Date: Sat, 11 Apr 2015 11:55:44 +0000	[thread overview]
Message-ID: <20150411115544.GB6540@thunk.org> (raw)
In-Reply-To: <20150409090308.GB17605@mwanda>

On Thu, Apr 09, 2015 at 12:03:08PM +0300, Dan Carpenter wrote:
> The callers don't care about the error so it doesn't make a difference,
> but static checkers complain so let's return an error code here.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks for pointing this out!  I will merge this with the next version
of the ext4 crypto patches.

						- Ted

WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Michael Halcrow <mhalcrow@google.com>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4 crypto: fix an error code in ext4_init_crypto()
Date: Sat, 11 Apr 2015 07:55:44 -0400	[thread overview]
Message-ID: <20150411115544.GB6540@thunk.org> (raw)
In-Reply-To: <20150409090308.GB17605@mwanda>

On Thu, Apr 09, 2015 at 12:03:08PM +0300, Dan Carpenter wrote:
> The callers don't care about the error so it doesn't make a difference,
> but static checkers complain so let's return an error code here.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks for pointing this out!  I will merge this with the next version
of the ext4 crypto patches.

						- Ted

  reply	other threads:[~2015-04-11 11:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09  9:03 [patch] ext4 crypto: fix an error code in ext4_init_crypto() Dan Carpenter
2015-04-09  9:03 ` Dan Carpenter
2015-04-11 11:55 ` Theodore Ts'o [this message]
2015-04-11 11:55   ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150411115544.GB6540@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mhalcrow@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.