From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [autobuild 1/4] autobuild-run: prevent send_result from failing when gathering config files
Date: Sun, 12 Apr 2015 19:20:51 +0200 [thread overview]
Message-ID: <20150412192051.5d747e28@free-electrons.com> (raw)
In-Reply-To: <1428849285-21092-1-git-send-email-s.martin49@gmail.com>
Dear Samuel Martin,
On Sun, 12 Apr 2015 16:34:42 +0200, Samuel Martin wrote:
> - Make sure using absolute paths in os.path.relpath();
> - os.makedirs() can fail if the directory already exists, so only create it
> when needed.
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
> ---
> scripts/autobuild-run | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/autobuild-run b/scripts/autobuild-run
> index 0e12080..a19d51b 100755
> --- a/scripts/autobuild-run
> +++ b/scripts/autobuild-run
> @@ -653,15 +653,16 @@ def send_results(result, **kwargs):
> if not reason:
> return
>
> - srcroot = os.path.join(outputdir, "build", '-'.join(reason))
> - destroot = os.path.join(resultdir, '-'.join(reason))
> + srcroot = os.path.abspath(os.path.join(outputdir, "build", '-'.join(reason)))
> + destroot = os.path.abspath(os.path.join(resultdir, '-'.join(reason)))
Can you explain why this is needed?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-04-12 17:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 14:34 [Buildroot] [autobuild 1/4] autobuild-run: prevent send_result from failing when gathering config files Samuel Martin
2015-04-12 14:34 ` [Buildroot] [autobuild 2/4] autobuild-run: also save CMake config log files on package failure Samuel Martin
2015-04-12 14:34 ` [Buildroot] [autobuild 3/4] autobuild-run: sanitize make options Samuel Martin
2015-04-12 17:22 ` Thomas Petazzoni
2015-04-12 18:20 ` Samuel Martin
2015-04-12 14:34 ` [Buildroot] [autobuild 4/4] autobuild-run: allow to change default git uri and branch through env. vars Samuel Martin
2015-04-12 17:26 ` Thomas Petazzoni
2015-04-12 18:06 ` Samuel Martin
2015-04-13 12:34 ` Matthew Weber
2015-04-12 17:20 ` Thomas Petazzoni [this message]
2015-04-12 18:15 ` [Buildroot] [autobuild 1/4] autobuild-run: prevent send_result from failing when gathering config files Samuel Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150412192051.5d747e28@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.