From: Christoffer Dall <christoffer.dall@linaro.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: marc.zyngier@arm.com, kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2] KVM: arm/arm64: avoid using kvm_run for in-kernel emulation
Date: Mon, 13 Apr 2015 11:57:34 +0200 [thread overview]
Message-ID: <20150413095734.GH6186@cbox> (raw)
In-Reply-To: <1428677987-15494-1-git-send-email-andre.przywara@arm.com>
On Fri, Apr 10, 2015 at 03:59:47PM +0100, Andre Przywara wrote:
> Our in-kernel VGIC emulation still uses struct kvm_run briefly before
> writing back the emulation result into the guest register.
> Although this particular case looks safe from an exploitation
> perspective, we can save some unneeded copying at the end of the VGIC
> emulation code.
> Replace the usage of struct kvm_run in favour of passing separate
> parameters in io_mem_abort(). Since the write back is now handled
> for all kvm_io_bus users, we can get rid of it in the VGIC.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: christoffer.dall@linaro.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] KVM: arm/arm64: avoid using kvm_run for in-kernel emulation
Date: Mon, 13 Apr 2015 11:57:34 +0200 [thread overview]
Message-ID: <20150413095734.GH6186@cbox> (raw)
In-Reply-To: <1428677987-15494-1-git-send-email-andre.przywara@arm.com>
On Fri, Apr 10, 2015 at 03:59:47PM +0100, Andre Przywara wrote:
> Our in-kernel VGIC emulation still uses struct kvm_run briefly before
> writing back the emulation result into the guest register.
> Although this particular case looks safe from an exploitation
> perspective, we can save some unneeded copying at the end of the VGIC
> emulation code.
> Replace the usage of struct kvm_run in favour of passing separate
> parameters in io_mem_abort(). Since the write back is now handled
> for all kvm_io_bus users, we can get rid of it in the VGIC.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
next prev parent reply other threads:[~2015-04-13 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-10 14:59 [PATCH v2] KVM: arm/arm64: avoid using kvm_run for in-kernel emulation Andre Przywara
2015-04-10 14:59 ` Andre Przywara
2015-04-13 9:57 ` Christoffer Dall [this message]
2015-04-13 9:57 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150413095734.GH6186@cbox \
--to=christoffer.dall@linaro.org \
--cc=andre.przywara@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marc.zyngier@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.