* [PATCH][meta-selinux] tar: cleanup duplicate PACKAGECONFIG @ 2015-04-13 9:24 wenzong.fan 2015-04-13 10:47 ` Martin Jansa 0 siblings, 1 reply; 3+ messages in thread From: wenzong.fan @ 2015-04-13 9:24 UTC (permalink / raw) To: yocto From: Wenzong Fan <wenzong.fan@windriver.com> The tar_1.28.bb has defined this: PACKAGECONFIG[acl] = "--with-posix-acls, --without-posix-acls, acl," Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com> --- recipes-extended/tar/tar_%.bbappend | 6 ------ 1 file changed, 6 deletions(-) diff --git a/recipes-extended/tar/tar_%.bbappend b/recipes-extended/tar/tar_%.bbappend index 54c8a90..53d381e 100644 --- a/recipes-extended/tar/tar_%.bbappend +++ b/recipes-extended/tar/tar_%.bbappend @@ -2,10 +2,4 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" inherit with-selinux - PACKAGECONFIG += "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}" - -# configure has no acl enable/disable options! -# -PACKAGECONFIG[acl] = ",,acl," - -- 1.9.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH][meta-selinux] tar: cleanup duplicate PACKAGECONFIG 2015-04-13 9:24 [PATCH][meta-selinux] tar: cleanup duplicate PACKAGECONFIG wenzong.fan @ 2015-04-13 10:47 ` Martin Jansa 2015-04-13 10:50 ` Martin Jansa 0 siblings, 1 reply; 3+ messages in thread From: Martin Jansa @ 2015-04-13 10:47 UTC (permalink / raw) To: wenzong.fan; +Cc: yocto [-- Attachment #1: Type: text/plain, Size: 1366 bytes --] On Mon, Apr 13, 2015 at 05:24:23PM +0800, wenzong.fan@windriver.com wrote: > From: Wenzong Fan <wenzong.fan@windriver.com> > > The tar_1.28.bb has defined this: > > PACKAGECONFIG[acl] = "--with-posix-acls, --without-posix-acls, acl," > > Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com> > --- > recipes-extended/tar/tar_%.bbappend | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/recipes-extended/tar/tar_%.bbappend b/recipes-extended/tar/tar_%.bbappend > index 54c8a90..53d381e 100644 > --- a/recipes-extended/tar/tar_%.bbappend > +++ b/recipes-extended/tar/tar_%.bbappend > @@ -2,10 +2,4 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > > inherit with-selinux > > - > PACKAGECONFIG += "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}" > - > -# configure has no acl enable/disable options! tar 1.17 (still available in oe-core) next to 1.28 doesn't have these options, so dropping this will cause QA warnings. Maybe should fix both in oe-core first and then you can even drop "PACKAGECONFIG +=" line. > -# > -PACKAGECONFIG[acl] = ",,acl," > - > -- > 1.9.1 > > -- > _______________________________________________ > yocto mailing list > yocto@yoctoproject.org > https://lists.yoctoproject.org/listinfo/yocto -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 188 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][meta-selinux] tar: cleanup duplicate PACKAGECONFIG 2015-04-13 10:47 ` Martin Jansa @ 2015-04-13 10:50 ` Martin Jansa 0 siblings, 0 replies; 3+ messages in thread From: Martin Jansa @ 2015-04-13 10:50 UTC (permalink / raw) To: wenzong.fan; +Cc: yocto [-- Attachment #1: Type: text/plain, Size: 2443 bytes --] On Mon, Apr 13, 2015 at 12:47:19PM +0200, Martin Jansa wrote: > On Mon, Apr 13, 2015 at 05:24:23PM +0800, wenzong.fan@windriver.com wrote: > > From: Wenzong Fan <wenzong.fan@windriver.com> > > > > The tar_1.28.bb has defined this: > > > > PACKAGECONFIG[acl] = "--with-posix-acls, --without-posix-acls, acl," > > > > Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com> > > --- > > recipes-extended/tar/tar_%.bbappend | 6 ------ > > 1 file changed, 6 deletions(-) > > > > diff --git a/recipes-extended/tar/tar_%.bbappend b/recipes-extended/tar/tar_%.bbappend > > index 54c8a90..53d381e 100644 > > --- a/recipes-extended/tar/tar_%.bbappend > > +++ b/recipes-extended/tar/tar_%.bbappend > > @@ -2,10 +2,4 @@ FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > > > > inherit with-selinux > > > > - > > PACKAGECONFIG += "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}" > > - > > -# configure has no acl enable/disable options! > > tar 1.17 (still available in oe-core) next to 1.28 doesn't have these > options, so dropping this will cause QA warnings. Ah nevermind, it's fixed in master with: commit faf469f9b5fbf794311d83db26cdf7f1042785c0 Author: Robert Yang <liezhi.yang@windriver.com> Date: Tue Jan 27 00:31:21 2015 -0800 tar 1.17: fix unknown-configure-option > Maybe should fix both in oe-core first and then you can even drop > "PACKAGECONFIG +=" line. Moving "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}" still seems to be useful as other recipes are also already using acl DISTRO_FEATURES. $ git grep PACKAGECONFIG.*DISTRO_FEATURES.*acl meta/recipes-core/coreutils/coreutils_6.9.bb:PACKAGECONFIG ??= "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}" meta/recipes-core/coreutils/coreutils_8.23.bb:PACKAGECONFIG_class-target ??= "${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}" meta/recipes-devtools/strace/strace_4.10.bb:PACKAGECONFIG_class-target ?= "libaio ${@bb.utils.contains('DISTRO_FEATURES', 'acl', 'acl', '', d)}" > > > -# > > -PACKAGECONFIG[acl] = ",,acl," > > - > > -- > > 1.9.1 > > > > -- > > _______________________________________________ > > yocto mailing list > > yocto@yoctoproject.org > > https://lists.yoctoproject.org/listinfo/yocto > > -- > Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com -- Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 188 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-13 10:50 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-04-13 9:24 [PATCH][meta-selinux] tar: cleanup duplicate PACKAGECONFIG wenzong.fan 2015-04-13 10:47 ` Martin Jansa 2015-04-13 10:50 ` Martin Jansa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.