All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 1/3] drm/msm: match wait_for_completion_timeout return type
Date: Mon, 13 Apr 2015 15:58:13 +0200	[thread overview]
Message-ID: <20150413135812.GA11328@ulmo.nvidia.com> (raw)
In-Reply-To: <1428757838-10431-1-git-send-email-hofrat@osadl.org>


[-- Attachment #1.1: Type: text/plain, Size: 1611 bytes --]

On Sat, Apr 11, 2015 at 03:10:36PM +0200, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int, this
> patch assigns the return value of wait_for_completion_timeout to an
> appropriately typed and named variable.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> 
> This was compile tested with qcom_defconfig +
> CONFIG_DRM=m (implies CONFIG_DRM_MSM=m)
> 
> Patch is against 4.0-rc7 (localversion-next is -next-20150410)
> 
>  drivers/gpu/drm/msm/edp/edp_ctrl.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> index 0ec5abd..831acd6 100644
> --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
> +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> @@ -1018,7 +1018,7 @@ static void edp_ctrl_off_worker(struct work_struct *work)
>  {
>  	struct edp_ctrl *ctrl = container_of(
>  				work, struct edp_ctrl, off_work);
> -	int ret;
> +	unsigned long time_left;
>  
>  	mutex_lock(&ctrl->dev_mutex);
>  
> @@ -1030,11 +1030,11 @@ static void edp_ctrl_off_worker(struct work_struct *work)
>  	reinit_completion(&ctrl->idle_comp);
>  	edp_state_ctrl(ctrl, EDP_STATE_CTRL_PUSH_IDLE);
>  
> -	ret = wait_for_completion_timeout(&ctrl->idle_comp,
> +	time_left = wait_for_completion_timeout(&ctrl->idle_comp,
>  						msecs_to_jiffies(500));
> -	if (ret <= 0)
> -		DBG("%s: idle pattern timedout, %d\n",
> -				__func__, ret);
> +	if (time_left <= 0)

Given that time_left is unsigned now, why bother with the "< 0"?

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Nicholas Mc Guire <hofrat@osadl.org>
Cc: David Airlie <airlied@linux.ie>, Rob Clark <robdclark@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Hai Li <hali@codeaurora.org>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] drm/msm: match wait_for_completion_timeout return type
Date: Mon, 13 Apr 2015 15:58:13 +0200	[thread overview]
Message-ID: <20150413135812.GA11328@ulmo.nvidia.com> (raw)
In-Reply-To: <1428757838-10431-1-git-send-email-hofrat@osadl.org>

[-- Attachment #1: Type: text/plain, Size: 1611 bytes --]

On Sat, Apr 11, 2015 at 03:10:36PM +0200, Nicholas Mc Guire wrote:
> return type of wait_for_completion_timeout is unsigned long not int, this
> patch assigns the return value of wait_for_completion_timeout to an
> appropriately typed and named variable.
> 
> Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> ---
> 
> This was compile tested with qcom_defconfig +
> CONFIG_DRM=m (implies CONFIG_DRM_MSM=m)
> 
> Patch is against 4.0-rc7 (localversion-next is -next-20150410)
> 
>  drivers/gpu/drm/msm/edp/edp_ctrl.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/edp/edp_ctrl.c b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> index 0ec5abd..831acd6 100644
> --- a/drivers/gpu/drm/msm/edp/edp_ctrl.c
> +++ b/drivers/gpu/drm/msm/edp/edp_ctrl.c
> @@ -1018,7 +1018,7 @@ static void edp_ctrl_off_worker(struct work_struct *work)
>  {
>  	struct edp_ctrl *ctrl = container_of(
>  				work, struct edp_ctrl, off_work);
> -	int ret;
> +	unsigned long time_left;
>  
>  	mutex_lock(&ctrl->dev_mutex);
>  
> @@ -1030,11 +1030,11 @@ static void edp_ctrl_off_worker(struct work_struct *work)
>  	reinit_completion(&ctrl->idle_comp);
>  	edp_state_ctrl(ctrl, EDP_STATE_CTRL_PUSH_IDLE);
>  
> -	ret = wait_for_completion_timeout(&ctrl->idle_comp,
> +	time_left = wait_for_completion_timeout(&ctrl->idle_comp,
>  						msecs_to_jiffies(500));
> -	if (ret <= 0)
> -		DBG("%s: idle pattern timedout, %d\n",
> -				__func__, ret);
> +	if (time_left <= 0)

Given that time_left is unsigned now, why bother with the "< 0"?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2015-04-13 13:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-11 13:10 [PATCH 1/3] drm/msm: match wait_for_completion_timeout return type Nicholas Mc Guire
2015-04-11 13:10 ` [PATCH 2/3] drm/msm: wait_for_completion_timeout return is never negative Nicholas Mc Guire
2015-04-11 13:10 ` [PATCH 3/3] drm/msm: drop redundant debug output Nicholas Mc Guire
2015-04-13 13:58 ` Thierry Reding [this message]
2015-04-13 13:58   ` [PATCH 1/3] drm/msm: match wait_for_completion_timeout return type Thierry Reding
2015-04-16  7:17   ` Nicholas Mc Guire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413135812.GA11328@ulmo.nvidia.com \
    --to=thierry.reding@gmail.com \
    --cc=broonie@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hofrat@osadl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.