All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerome Glisse <j.glisse@gmail.com>
To: Serguei Sagalovitch <serguei.sagalovitch@amd.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [RFC] drm/radeon: userfence IOCTL
Date: Mon, 13 Apr 2015 12:13:14 -0400	[thread overview]
Message-ID: <20150413161312.GE29334@gmail.com> (raw)
In-Reply-To: <552BE633.9020306@amd.com>

On Mon, Apr 13, 2015 at 11:52:19AM -0400, Serguei Sagalovitch wrote:
> > Given that the userspace wait fence ioctl has not way to know which
> > command buffer it is really waiting after then kernel has no knowledge
> > if this user fence will signal at all.
>
> We could pass BO handle as  parameter in the "fence ioctl" to rely on it so
> kernel will know which BO  it is waiting.

Christian code already do that, but this is not enough to know which cs
kernel is waiting for. See my other emails with Christian.

> 
> 
> > So a malicious user space (we always have to assume this thing exist)
> > could create a big VRAM BO and effectively pin it in VRAM leading to a GPU
> > DOS (denial of service).
>
> This problem  always exists. Malicious user space could allocate big BO and
> then submit shader running in loop which read/write from this BO.  It could
> also spawn processes which will do the same thing. IMHO the only way to
> improve situation is  to have GPU Scheduler to allow "unloading" such
> application.
>

Yes but the GPU lockup watchdog would kick in (thinking it is a GPU lockup)
and reset the GPU which is harsh but that is what we have now (well i think
the compute guys messed with that so it might no longer be the case).

So it is just about avoiding giving userspace more means to mess with thing.

Cheers,
Jérôme
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-04-13 16:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-13 14:52 [RFC] drm/radeon: userfence IOCTL Christian König
2015-04-13 14:52 ` [PATCH 1/3] drm/radeon: wait for BO move to finish on kmap Christian König
2015-04-13 14:52 ` [PATCH 2/3] drm/radeon: cleanup radeon_cs_get_ring Christian König
2015-04-13 14:52 ` [PATCH 3/3] drm/radeon: add userfence IOCTL Christian König
2015-04-13 17:23   ` Daniel Vetter
2015-04-13 17:51     ` Jerome Glisse
2015-04-13 18:26       ` Christian König
2015-04-13 19:48         ` Jerome Glisse
2015-04-14  8:17           ` Daniel Vetter
2015-04-13 17:27   ` Daniel Vetter
2015-04-13 15:25 ` [RFC] drm/radeon: " Serguei Sagalovitch
2015-04-13 15:35   ` Christian König
2015-04-13 15:37     ` Serguei Sagalovitch
2015-04-13 15:46     ` Jerome Glisse
2015-04-13 15:39   ` Jerome Glisse
2015-04-13 15:47     ` Christian König
2015-04-13 15:52     ` Serguei Sagalovitch
2015-04-13 16:13       ` Jerome Glisse [this message]
2015-04-13 15:31 ` Jerome Glisse
2015-04-13 15:45   ` Christian König
2015-04-13 16:08     ` Jerome Glisse
2015-04-13 16:55       ` Christian König
2015-04-13 17:46         ` Jerome Glisse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150413161312.GE29334@gmail.com \
    --to=j.glisse@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=serguei.sagalovitch@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.