* [libvirt test] 50401: regressions - FAIL
@ 2015-04-14 2:27 osstest service user
2015-04-14 9:33 ` [libvirt] [Xen-devel] " Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: osstest service user @ 2015-04-14 2:27 UTC (permalink / raw)
To: xen-devel; +Cc: ian.jackson
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3322 bytes --]
flight 50401 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/50401/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-armhf-libvirt 5 libvirt-build fail REGR. vs. 50368
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt-xsm 1 build-check(1) blocked n/a
test-armhf-armhf-libvirt 1 build-check(1) blocked n/a
test-amd64-i386-libvirt-xsm 11 guest-start fail never pass
test-amd64-amd64-libvirt-xsm 11 guest-start fail never pass
test-amd64-i386-libvirt 12 migrate-support-check fail never pass
test-amd64-amd64-libvirt 12 migrate-support-check fail never pass
version targeted for testing:
libvirt b487bb810ec95df862e7e80468c8e861ed80b0cb
baseline version:
libvirt 225aa80246d5e4a9e3a16ebd4c482525045da3db
------------------------------------------------------------
People who touched revisions under test:
Cédric Bosdonnat <cbosdonnat@suse.com>
Dawid Zamirski <dzamirski@datto.com>
Dmitry Guryanov <dguryanov@parallels.com>
Erik Skultety <eskultet@redhat.com>
John Ferlan <jferlan@redhat.com>
Ján Tomko <jtomko@redhat.com>
Lubomir Rintel <lkundrak@v3.sk>
Luyao Huang <lhuang@redhat.com>
Maxim Nestratov <mnestratov@parallels.com>
Michael Chapman <mike@very.puzzling.org>
Michal Privoznik <mprivozn@redhat.com>
Peter Krempa <pkrempa@redhat.com>
------------------------------------------------------------
jobs:
build-amd64-xsm pass
build-armhf-xsm pass
build-i386-xsm pass
build-amd64 pass
build-armhf pass
build-i386 pass
build-amd64-libvirt pass
build-armhf-libvirt fail
build-i386-libvirt pass
build-amd64-pvops pass
build-armhf-pvops pass
build-i386-pvops pass
test-amd64-amd64-libvirt-xsm fail
test-armhf-armhf-libvirt-xsm blocked
test-amd64-i386-libvirt-xsm fail
test-amd64-amd64-libvirt pass
test-armhf-armhf-libvirt blocked
test-amd64-i386-libvirt pass
------------------------------------------------------------
sg-report-flight on osstest.test-lab.xenproject.org
logs: /home/osstest/pub/logs
images: /home/osstest/pub/images
Logs, config files, etc. are available at
http://logs.test-lab.xenproject.org/osstest/logs
Test harness code can be found at
http://xenbits.xen.org/gitweb?p=osstest.git;a=summary
Not pushing.
(No revision log; it would be 848 lines long.)
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [libvirt] [Xen-devel] [libvirt test] 50401: regressions - FAIL
2015-04-14 2:27 [libvirt test] 50401: regressions - FAIL osstest service user
@ 2015-04-14 9:33 ` Ian Campbell
2015-04-14 9:37 ` Daniel P. Berrange
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2015-04-14 9:33 UTC (permalink / raw)
To: libvir-list, John Ferlan; +Cc: xen-devel, ian.jackson
On Tue, 2015-04-14 at 02:27 +0000, osstest service user wrote:
> flight 50401 libvirt real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/50401/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> build-armhf-libvirt 5 libvirt-build fail REGR. vs. 50368
[...]
Per
http://logs.test-lab.xenproject.org/osstest/logs/50401/build-armhf-libvirt/5.ts-libvirt-build.log this is:
qemu/qemu_driver.c: In function 'qemuDomainAddCgroupForThread':
qemu/qemu_driver.c:4641:34: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
qemu/qemu_driver.c: In function 'qemuDomainHotplugAddPin':
qemu/qemu_driver.c:4674:29: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
qemu/qemu_driver.c: In function 'qemuDomainHotplugPinThread':
qemu/qemu_driver.c:4702:32: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
qemu/qemu_driver.c: In function 'qemuDomainDelCgroupForThread':
qemu/qemu_driver.c:4733:34: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
cc1: all warnings being treated as errors
This seems to be a general issue unrelated to Xen.
> version targeted for testing:
> libvirt b487bb810ec95df862e7e80468c8e861ed80b0cb
> baseline version:
> libvirt 225aa80246d5e4a9e3a16ebd4c482525045da3db
After a quick glance I don't see a fix post-b487bb810ec9 either in
master or on the libvirt list.
Looking at the range under test it looks like one or more of John's
changes is adding parameters called index, shadowing index(3) from
<strings.h>.
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [libvirt] [Xen-devel] [libvirt test] 50401: regressions - FAIL
2015-04-14 9:33 ` [libvirt] [Xen-devel] " Ian Campbell
@ 2015-04-14 9:37 ` Daniel P. Berrange
2015-04-15 10:17 ` [libvirt] " Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Daniel P. Berrange @ 2015-04-14 9:37 UTC (permalink / raw)
To: Ian Campbell; +Cc: libvir-list, xen-devel, ian.jackson
On Tue, Apr 14, 2015 at 10:33:45AM +0100, Ian Campbell wrote:
> On Tue, 2015-04-14 at 02:27 +0000, osstest service user wrote:
> > flight 50401 libvirt real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/50401/
> >
> > Regressions :-(
> >
> > Tests which did not succeed and are blocking,
> > including tests which could not be run:
> > build-armhf-libvirt 5 libvirt-build fail REGR. vs. 50368
> [...]
> Per
> http://logs.test-lab.xenproject.org/osstest/logs/50401/build-armhf-libvirt/5.ts-libvirt-build.log this is:
>
> qemu/qemu_driver.c: In function 'qemuDomainAddCgroupForThread':
> qemu/qemu_driver.c:4641:34: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> qemu/qemu_driver.c: In function 'qemuDomainHotplugAddPin':
> qemu/qemu_driver.c:4674:29: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> qemu/qemu_driver.c: In function 'qemuDomainHotplugPinThread':
> qemu/qemu_driver.c:4702:32: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> qemu/qemu_driver.c: In function 'qemuDomainDelCgroupForThread':
> qemu/qemu_driver.c:4733:34: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> cc1: all warnings being treated as errors
>
>
> This seems to be a general issue unrelated to Xen.
>
> > version targeted for testing:
> > libvirt b487bb810ec95df862e7e80468c8e861ed80b0cb
> > baseline version:
> > libvirt 225aa80246d5e4a9e3a16ebd4c482525045da3db
>
> After a quick glance I don't see a fix post-b487bb810ec9 either in
> master or on the libvirt list.
>
> Looking at the range under test it looks like one or more of John's
> changes is adding parameters called index, shadowing index(3) from
> <strings.h>.
Yeah, we've had this problem several times before - we usually just
do a s/index/idx/ or similar to address it.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [libvirt] [libvirt test] 50401: regressions - FAIL
2015-04-14 9:37 ` Daniel P. Berrange
@ 2015-04-15 10:17 ` Ian Campbell
2015-04-15 13:16 ` [libvirt] [Xen-devel] " Daniel P. Berrange
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2015-04-15 10:17 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: libvir-list, John Ferlan, xen-devel, ian.jackson
On Tue, 2015-04-14 at 10:37 +0100, Daniel P. Berrange wrote:
> On Tue, Apr 14, 2015 at 10:33:45AM +0100, Ian Campbell wrote:
> > On Tue, 2015-04-14 at 02:27 +0000, osstest service user wrote:
> > > flight 50401 libvirt real [real]
> > > http://logs.test-lab.xenproject.org/osstest/logs/50401/
> > >
> > > Regressions :-(
> > >
> > > Tests which did not succeed and are blocking,
> > > including tests which could not be run:
> > > build-armhf-libvirt 5 libvirt-build fail REGR. vs. 50368
> > [...]
> > Per
> > http://logs.test-lab.xenproject.org/osstest/logs/50401/build-armhf-libvirt/5.ts-libvirt-build.log this is:
> >
> > qemu/qemu_driver.c: In function 'qemuDomainAddCgroupForThread':
> > qemu/qemu_driver.c:4641:34: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> > qemu/qemu_driver.c: In function 'qemuDomainHotplugAddPin':
> > qemu/qemu_driver.c:4674:29: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> > qemu/qemu_driver.c: In function 'qemuDomainHotplugPinThread':
> > qemu/qemu_driver.c:4702:32: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> > qemu/qemu_driver.c: In function 'qemuDomainDelCgroupForThread':
> > qemu/qemu_driver.c:4733:34: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> > cc1: all warnings being treated as errors
> >
> >
> > This seems to be a general issue unrelated to Xen.
> >
> > > version targeted for testing:
> > > libvirt b487bb810ec95df862e7e80468c8e861ed80b0cb
> > > baseline version:
> > > libvirt 225aa80246d5e4a9e3a16ebd4c482525045da3db
> >
> > After a quick glance I don't see a fix post-b487bb810ec9 either in
> > master or on the libvirt list.
> >
> > Looking at the range under test it looks like one or more of John's
> > changes is adding parameters called index, shadowing index(3) from
> > <strings.h>.
>
> Yeah, we've had this problem several times before - we usually just
> do a s/index/idx/ or similar to address it.
I see this is now fixed in libvirt.git#master, thanks.
However, I would just comment that contrary to the commit message, I
don't think there is anything the Xen build has done which caused this,
I think it's down to the LIBVIRT_COMPILE_WARNINGS macro which ends up
enabling Wshadow if it was available on the system which ran autogen and
on the compiling system.
Our builds run on Debian Wheezy, which IIRC uses gcc 4.4 which isn't
unusual...
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [libvirt] [Xen-devel] [libvirt test] 50401: regressions - FAIL
2015-04-15 10:17 ` [libvirt] " Ian Campbell
@ 2015-04-15 13:16 ` Daniel P. Berrange
2015-04-17 9:58 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Daniel P. Berrange @ 2015-04-15 13:16 UTC (permalink / raw)
To: Ian Campbell; +Cc: libvir-list, xen-devel, ian.jackson
On Wed, Apr 15, 2015 at 11:17:29AM +0100, Ian Campbell wrote:
> On Tue, 2015-04-14 at 10:37 +0100, Daniel P. Berrange wrote:
> > On Tue, Apr 14, 2015 at 10:33:45AM +0100, Ian Campbell wrote:
> > > On Tue, 2015-04-14 at 02:27 +0000, osstest service user wrote:
> > > > flight 50401 libvirt real [real]
> > > > http://logs.test-lab.xenproject.org/osstest/logs/50401/
> > > >
> > > > Regressions :-(
> > > >
> > > > Tests which did not succeed and are blocking,
> > > > including tests which could not be run:
> > > > build-armhf-libvirt 5 libvirt-build fail REGR. vs. 50368
> > > [...]
> > > Per
> > > http://logs.test-lab.xenproject.org/osstest/logs/50401/build-armhf-libvirt/5.ts-libvirt-build.log this is:
> > >
> > > qemu/qemu_driver.c: In function 'qemuDomainAddCgroupForThread':
> > > qemu/qemu_driver.c:4641:34: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> > > qemu/qemu_driver.c: In function 'qemuDomainHotplugAddPin':
> > > qemu/qemu_driver.c:4674:29: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> > > qemu/qemu_driver.c: In function 'qemuDomainHotplugPinThread':
> > > qemu/qemu_driver.c:4702:32: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> > > qemu/qemu_driver.c: In function 'qemuDomainDelCgroupForThread':
> > > qemu/qemu_driver.c:4733:34: error: declaration of 'index' shadows a global declaration [-Werror=shadow]
> > > cc1: all warnings being treated as errors
> > >
> > >
> > > This seems to be a general issue unrelated to Xen.
> > >
> > > > version targeted for testing:
> > > > libvirt b487bb810ec95df862e7e80468c8e861ed80b0cb
> > > > baseline version:
> > > > libvirt 225aa80246d5e4a9e3a16ebd4c482525045da3db
> > >
> > > After a quick glance I don't see a fix post-b487bb810ec9 either in
> > > master or on the libvirt list.
> > >
> > > Looking at the range under test it looks like one or more of John's
> > > changes is adding parameters called index, shadowing index(3) from
> > > <strings.h>.
> >
> > Yeah, we've had this problem several times before - we usually just
> > do a s/index/idx/ or similar to address it.
>
> I see this is now fixed in libvirt.git#master, thanks.
>
> However, I would just comment that contrary to the commit message, I
> don't think there is anything the Xen build has done which caused this,
> I think it's down to the LIBVIRT_COMPILE_WARNINGS macro which ends up
> enabling Wshadow if it was available on the system which ran autogen and
> on the compiling system.
>
> Our builds run on Debian Wheezy, which IIRC uses gcc 4.4 which isn't
> unusual...
Yeah, there is nothing Xen specific about the problem - it is entirely
down to the build toolchain & compiler options.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [libvirt] [Xen-devel] [libvirt test] 50401: regressions - FAIL
2015-04-15 13:16 ` [libvirt] [Xen-devel] " Daniel P. Berrange
@ 2015-04-17 9:58 ` Ian Campbell
0 siblings, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2015-04-17 9:58 UTC (permalink / raw)
To: Daniel P. Berrange; +Cc: libvir-list, xen-devel, ian.jackson, Peter Krempa
On Wed, 2015-04-15 at 14:16 +0100, Daniel P. Berrange wrote:
> Yeah, there is nothing Xen specific about the problem - it is entirely
> down to the build toolchain & compiler options.
FYI our bisector has now tripped over another related problem,
http://lists.xen.org/archives/html/xen-devel/2015-04/msg01900.html
http://lists.xen.org/archives/html/xen-devel/2015-04/msg01968.html
in particular:
http://logs.test-lab.xenproject.org/osstest/logs/50460/build-armhf-libvirt/5.ts-libvirt-build.log:
qemu/qemu_domain.c: In function 'qemuDomainSupportsBlockJobs':
qemu/qemu_domain.c:3067:11: error: declaration of 'sync' shadows a global
declaration [-Werror=shadow]
cc1: all warnings being treated as errors
Essentially another instance of the same class of issue, in this case
arising from:
commit 1eccac1d2da7bbe97e1df25fd0ddac6e71b0794a
Author: Peter Krempa <pkrempa@redhat.com>
Date: Tue Mar 31 17:29:35 2015 +0200
qemu: domain: Add helper to check block job support
Given the code in autoconf to enable essentially all warnings I'm a bit
surprised -Wshadow isn't being enabled for everyone -- I thought it was
quite a long standing warning.
I'm also not sure why we are having a sudden rash of these now.
But perhaps it is worth adding Wshadow to the set of excluded options
until either it is more widely supported or the libvirt code base has
been audited? I can send such a patch if you think that's desirable.
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-04-17 9:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-14 2:27 [libvirt test] 50401: regressions - FAIL osstest service user
2015-04-14 9:33 ` [libvirt] [Xen-devel] " Ian Campbell
2015-04-14 9:37 ` Daniel P. Berrange
2015-04-15 10:17 ` [libvirt] " Ian Campbell
2015-04-15 13:16 ` [libvirt] [Xen-devel] " Daniel P. Berrange
2015-04-17 9:58 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.