From: Andrei Borzenkov <arvidjaar@gmail.com>
To: Toomas Soome <tsoome@me.com>
Cc: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] grub-core/lib/libgcrypt/cipher/rijndael.c 2 warnings.
Date: Wed, 15 Apr 2015 08:16:24 +0300 [thread overview]
Message-ID: <20150415081624.6014914d@opensuse.site> (raw)
In-Reply-To: <D3FEC588-7151-409B-930B-CDE275003B7B@me.com>
В Mon, 13 Apr 2015 20:32:53 +0300
Toomas Soome <tsoome@me.com> пишет:
> hi!
>
> just checked the git://git.gnupg.org/libgcrypt.git - apparently it has been changed compared to one included in grub; the int i versus unsigned keylen is still there (visual inspection), the { } were inserted to if (0) ; statement.
>
> so second half is already fixed. I did report the signed/unsigned compare issue to gcrypt-devel, but then the question is about updating libcgrypt in grub;
It gets updated every now and then. "Upstream first" makes sure that if
we add local patch it won't be lost next time library is pulled in.
Just to be sure - these are just warnings, right? They do not cause
build failure or any regression?
next prev parent reply other threads:[~2015-04-15 5:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-13 10:47 [PATCH] grub-core/lib/libgcrypt/cipher/rijndael.c 2 warnings Toomas Soome
2015-04-13 16:56 ` Andrei Borzenkov
2015-04-13 17:32 ` Toomas Soome
2015-04-15 5:16 ` Andrei Borzenkov [this message]
2015-04-15 5:44 ` Toomas Soome
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415081624.6014914d@opensuse.site \
--to=arvidjaar@gmail.com \
--cc=grub-devel@gnu.org \
--cc=tsoome@me.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.