From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Jonathan Corbet <corbet@lwn.net>,
Wolfram Sang <wsa@the-dreams.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, Willy Tarreau <willy@meta-x.org>,
Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH 1/4] parport: modify parport subsystem to use devicemodel
Date: Wed, 15 Apr 2015 12:32:20 +0300 [thread overview]
Message-ID: <20150415093220.GK10964@mwanda> (raw)
In-Reply-To: <20150415092055.GA3198@sudip-PC>
On Wed, Apr 15, 2015 at 02:50:55PM +0530, Sudip Mukherjee wrote:
> this PARPORT_DEVPROC_REGISTERED flag is cleared in parport_unregister_device()
> and is set in parport_register_dev[ice], so when we call
> parport_register_device() or parport_register_dev() it will be not set
> and the condition will always be true.
The question of how to handle impossible conditions is always tricky.
:P In this case just remove the condition.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: devel@driverdev.osuosl.org,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Wolfram Sang <wsa@the-dreams.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, Willy Tarreau <willy@meta-x.org>,
Jean Delvare <jdelvare@suse.de>
Subject: Re: [PATCH 1/4] parport: modify parport subsystem to use devicemodel
Date: Wed, 15 Apr 2015 12:32:20 +0300 [thread overview]
Message-ID: <20150415093220.GK10964@mwanda> (raw)
In-Reply-To: <20150415092055.GA3198@sudip-PC>
On Wed, Apr 15, 2015 at 02:50:55PM +0530, Sudip Mukherjee wrote:
> this PARPORT_DEVPROC_REGISTERED flag is cleared in parport_unregister_device()
> and is set in parport_register_dev[ice], so when we call
> parport_register_device() or parport_register_dev() it will be not set
> and the condition will always be true.
The question of how to handle impossible conditions is always tricky.
:P In this case just remove the condition.
regards,
dan carpenter
next prev parent reply other threads:[~2015-04-15 9:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 7:48 [PATCH 0/4] convert parport to device-model Sudip Mukherjee
2015-04-15 7:48 ` Sudip Mukherjee
2015-04-15 7:48 ` [PATCH 1/4] parport: modify parport subsystem to use devicemodel Sudip Mukherjee
2015-04-15 7:48 ` Sudip Mukherjee
2015-04-15 8:27 ` Dan Carpenter
2015-04-15 8:27 ` Dan Carpenter
2015-04-15 9:20 ` Sudip Mukherjee
2015-04-15 9:20 ` Sudip Mukherjee
2015-04-15 9:32 ` Dan Carpenter [this message]
2015-04-15 9:32 ` Dan Carpenter
2015-04-15 9:45 ` Dan Carpenter
2015-04-15 9:45 ` Dan Carpenter
2015-04-15 10:28 ` Sudip Mukherjee
2015-04-15 8:33 ` Dan Carpenter
2015-04-15 8:33 ` Dan Carpenter
2015-04-15 9:24 ` Sudip Mukherjee
2015-04-15 13:23 ` Greg Kroah-Hartman
2015-04-15 13:23 ` Greg Kroah-Hartman
2015-04-15 13:31 ` Greg Kroah-Hartman
[not found] ` <20150415133115.GG21491-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2015-04-15 16:13 ` Sudip Mukherjee
2015-04-15 16:13 ` Sudip Mukherjee
2015-04-16 9:50 ` Sudip Mukherjee
2015-04-15 7:48 ` [PATCH 2/4] parport: update TODO and documentation Sudip Mukherjee
2015-04-15 7:48 ` [PATCH 3/4] i2c-parport: use device-model parport Sudip Mukherjee
2015-04-15 7:48 ` Sudip Mukherjee
2015-04-15 7:48 ` [PATCH 4/4] staging: panel: use parport in device-model Sudip Mukherjee
2015-04-15 7:48 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415093220.GK10964@mwanda \
--to=dan.carpenter@oracle.com \
--cc=corbet@lwn.net \
--cc=devel@driverdev.osuosl.org \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jdelvare@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=willy@meta-x.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.