All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <treding@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net: Use u32 instead of ulong for transaction ID in bootp
Date: Wed, 15 Apr 2015 14:04:04 +0200	[thread overview]
Message-ID: <20150415120403.GJ20875@ulmo.nvidia.com> (raw)
In-Reply-To: <c197c446b6429fa46b11b6624cf08b0391cdf102.1429095056.git.michal.simek@xilinx.com>

On Wed, Apr 15, 2015 at 12:50:59PM +0200, Michal Simek wrote:
> From: Siva Durga Prasad Paladugu <siva.durga.paladugu@xilinx.com>
> 
> Based on rfc951 transaction ID has 4 bytes which is not the case when
> ulong type is used on ARM64.
> Use u32 type which is well defined for all archs.
> 
> BOOTP_VENDOR_MAGIC is also 4 bytes.
> 
> Based on RFC1048 Time Offset (code 2) is also 4bytes long
> and IP Address Lease Time also.
> 
> The patch converts NetCopyLong to netcopy32 and NetReadLong to netread32
> to follow u-boot coding style.
> 
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  include/net.h | 14 +++++++-------
>  net/bootp.c   | 18 +++++++++---------
>  net/bootp.h   |  2 +-
>  3 files changed, 17 insertions(+), 17 deletions(-)

Looks reasonable to me:

Reviewed-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150415/415327c0/attachment.sig>

  reply	other threads:[~2015-04-15 12:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-15 10:50 [U-Boot] [PATCH] net: Use u32 instead of ulong for transaction ID in bootp Michal Simek
2015-04-15 12:04 ` Thierry Reding [this message]
2015-04-15 13:45 ` Joe Hershberger
2015-04-15 16:36   ` Michal Simek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150415120403.GJ20875@ulmo.nvidia.com \
    --to=treding@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.