From: Catalin Marinas <catalin.marinas@arm.com>
To: Wang Kai <morgan.wang@huawei.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kmemleak: record accurate early log buffer count and report when exceeded
Date: Wed, 15 Apr 2015 16:07:12 +0100 [thread overview]
Message-ID: <20150415150712.GD22741@localhost> (raw)
In-Reply-To: <1429098292-76415-1-git-send-email-morgan.wang@huawei.com>
BTW, you misspelled the LKML address (I fixed it: s/\.or/\.org/)
On Wed, Apr 15, 2015 at 12:44:52PM +0100, Wang Kai wrote:
> In log_early function, crt_early_log should also count once when
> 'crt_early_log >= ARRAY_SIZE(early_log)'. Otherwise the reported
> count from kmemleak_init is one less than 'actual number'.
>
> Then, in kmemleak_init, if early_log buffer size equal actual
> number, kmemleak will init sucessful, so change warning condition
> to 'crt_early_log > ARRAY_SIZE(early_log)'.
>
> Signed-off-by: Wang Kai <morgan.wang@huawei.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Wang Kai <morgan.wang@huawei.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kmemleak: record accurate early log buffer count and report when exceeded
Date: Wed, 15 Apr 2015 16:07:12 +0100 [thread overview]
Message-ID: <20150415150712.GD22741@localhost> (raw)
In-Reply-To: <1429098292-76415-1-git-send-email-morgan.wang@huawei.com>
BTW, you misspelled the LKML address (I fixed it: s/\.or/\.org/)
On Wed, Apr 15, 2015 at 12:44:52PM +0100, Wang Kai wrote:
> In log_early function, crt_early_log should also count once when
> 'crt_early_log >= ARRAY_SIZE(early_log)'. Otherwise the reported
> count from kmemleak_init is one less than 'actual number'.
>
> Then, in kmemleak_init, if early_log buffer size equal actual
> number, kmemleak will init sucessful, so change warning condition
> to 'crt_early_log > ARRAY_SIZE(early_log)'.
>
> Signed-off-by: Wang Kai <morgan.wang@huawei.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
next prev parent reply other threads:[~2015-04-15 15:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 11:44 [PATCH] kmemleak: record accurate early log buffer count and report when exceeded Wang Kai
2015-04-15 15:07 ` Catalin Marinas [this message]
2015-04-15 15:07 ` Catalin Marinas
-- strict thread matches above, loose matches on Subject: below --
2015-04-15 11:49 Wang Kai
2015-04-15 11:49 ` Wang Kai
2015-04-15 15:13 ` Catalin Marinas
2015-04-15 15:13 ` Catalin Marinas
2015-04-15 23:23 ` Wang Kai
2015-04-15 23:23 ` Wang Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150415150712.GD22741@localhost \
--to=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=morgan.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.