From: Ingo Molnar <mingo@kernel.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, x86@kernel.org,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86: Enable fast 32-bit put_user_64 for copy_to_user
Date: Thu, 16 Apr 2015 09:28:02 +0200 [thread overview]
Message-ID: <20150416072802.GA4998@gmail.com> (raw)
In-Reply-To: <1429091486-11443-1-git-send-email-chris@chris-wilson.co.uk>
* Chris Wilson <chris@chris-wilson.co.uk> wrote:
> For fixed sized copies, copy_to_user() will utilize __put_user_size
> fastpaths. However, it is missing the translation for 64bit copies on
> x86/32. Testing on a Pinetrail Atom, the 64 bit put_user fastpath is
> substantially faster than the generic copy_to_user() fallback.
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> CC: linux-kernel@vger.kernel.org
The patch makes sense, but your Signed-off-by line is missing.
Thanks,
Ingo
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: Enable fast 32-bit put_user_64 for copy_to_user
Date: Thu, 16 Apr 2015 09:28:02 +0200 [thread overview]
Message-ID: <20150416072802.GA4998@gmail.com> (raw)
In-Reply-To: <1429091486-11443-1-git-send-email-chris@chris-wilson.co.uk>
* Chris Wilson <chris@chris-wilson.co.uk> wrote:
> For fixed sized copies, copy_to_user() will utilize __put_user_size
> fastpaths. However, it is missing the translation for 64bit copies on
> x86/32. Testing on a Pinetrail Atom, the 64 bit put_user fastpath is
> substantially faster than the generic copy_to_user() fallback.
>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> CC: linux-kernel@vger.kernel.org
The patch makes sense, but your Signed-off-by line is missing.
Thanks,
Ingo
next prev parent reply other threads:[~2015-04-16 7:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 9:51 [PATCH] x86: Enable fast 32-bit put_user_64 for copy_to_user Chris Wilson
2015-04-15 9:51 ` Chris Wilson
2015-04-15 22:01 ` shuang.he
2015-04-16 7:28 ` Ingo Molnar [this message]
2015-04-16 7:28 ` Ingo Molnar
2015-04-16 7:40 ` Chris Wilson
2015-04-16 16:15 ` [tip:x86/asm] x86/asm: Enable fast 32-bit put_user_64() for copy_to_user() tip-bot for Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416072802.GA4998@gmail.com \
--to=mingo@kernel.org \
--cc=chris@chris-wilson.co.uk \
--cc=hpa@zytor.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.