From: Peter Zijlstra <peterz@infradead.org>
To: Kan Liang <kan.liang@intel.com>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
acme@infradead.org, eranian@google.com, andi@firstfloor.org
Subject: Re: [PATCH V6 3/6] perf, x86: large PEBS interrupt threshold
Date: Thu, 16 Apr 2015 20:45:44 +0200 [thread overview]
Message-ID: <20150416184544.GB23123@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1428597466-8154-4-git-send-email-kan.liang@intel.com>
On Thu, Apr 09, 2015 at 12:37:43PM -0400, Kan Liang wrote:
> + /*
> + * When the event is constrained enough we can use a larger
> + * threshold and run the event with less frequent PMI.
> + */
> + if (0 && /* disable this temporarily */
This is a good hint your patches are ordered wrong.
> + (hwc->flags & PERF_X86_EVENT_AUTO_RELOAD)) {
> + threshold = ds->pebs_absolute_maximum -
> + x86_pmu.max_pebs_events * x86_pmu.pebs_record_size;
> + } else {
> + threshold = ds->pebs_buffer_base + x86_pmu.pebs_record_size;
> + }
> +
next prev parent reply other threads:[~2015-04-16 18:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 16:37 [PATCH V6 0/6] large PEBS interrupt threshold Kan Liang
2015-04-09 16:37 ` [PATCH V6 1/6] perf, x86: use the PEBS auto reload mechanism when possible Kan Liang
2015-04-09 16:37 ` [PATCH V6 2/6] perf, x86: introduce setup_pebs_sample_data() Kan Liang
2015-04-09 16:37 ` [PATCH V6 3/6] perf, x86: large PEBS interrupt threshold Kan Liang
2015-04-15 17:14 ` Peter Zijlstra
2015-04-15 17:48 ` Liang, Kan
2015-04-15 18:10 ` Peter Zijlstra
2015-04-15 18:05 ` Peter Zijlstra
2015-04-15 18:35 ` Liang, Kan
2015-04-15 18:41 ` Peter Zijlstra
2015-04-16 18:45 ` Peter Zijlstra [this message]
2015-04-09 16:37 ` [PATCH V6 4/6] perf, x86: handle multiple records in PEBS buffer Kan Liang
2015-04-09 21:01 ` Andi Kleen
2015-04-15 18:28 ` Peter Zijlstra
2015-04-15 18:36 ` Peter Zijlstra
2015-04-16 12:53 ` Peter Zijlstra
2015-04-17 8:11 ` Peter Zijlstra
2015-04-17 12:50 ` Liang, Kan
2015-04-17 13:12 ` Peter Zijlstra
2015-04-17 14:19 ` Liang, Kan
2015-04-17 14:44 ` Peter Zijlstra
2015-04-17 18:20 ` Andi Kleen
2015-04-17 18:25 ` Peter Zijlstra
2015-04-09 16:37 ` [PATCH V6 5/6] perf, x86: drain PEBS buffer during context switch Kan Liang
2015-04-09 16:37 ` [PATCH V6 6/6] perf, x86: enlarge PEBS buffer Kan Liang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150416184544.GB23123@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@infradead.org \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.