All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Jansa <martin.jansa@gmail.com>
To: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
Cc: openembedded-core@openembedded.org, bitbake-devel@lists.openembedded.org
Subject: Re: [PATCH 1/1] [daisy][dizzy] data.py: fixes bad substitution when running devshell
Date: Fri, 17 Apr 2015 02:31:50 +0200	[thread overview]
Message-ID: <20150417003150.GC2341@jama> (raw)
In-Reply-To: <1428610909-12661-2-git-send-email-alejandro.hernandez@linux.intel.com>

On Thu, Apr 09, 2015 at 03:21:49PM -0500, Alejandro Hernandez wrote:
> From: Richard Tollerton <rich.tollerton@ni.com>
> 
> Running bitbake inside make results in the exported environment variable
> MAKEOVERRIDES="${-*-command-variables-*-}", which the shell chokes on
> when trying to expand it. But of course, it probably shouldn't have been
> trying to expand it in the first place -- so just escape the dollar
> sign.
> 
> (Bitbake rev: 18cd0ce6a55c9065c3f1bf223b47d817b5efcd8f)

This was already cherry-picked to 1.24 where it IIRC breaks powertop
build with current oe-core/dizzy.

Please backport:

commit a3e9b391e1024d6d2e256b75c214d34e6693e332
Author: Martin Jansa <martin.jansa@gmail.com>
Date:   Thu Dec 18 15:54:14 2014 +0100

    powertop: Fix build for !uclibc
    
    * EXTRA_LDFLAGS isn't defined for !uclibc and configure fails
      when it reads it unexpanded, see config.log snippet:

to unblock Dizzy builds and backport the same to Dylan before merging
this to 2.22.

> 
> Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
> 
> ---
>  bitbake/lib/bb/data.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/bitbake/lib/bb/data.py b/bitbake/lib/bb/data.py
> index eb628c7..82eefef 100644
> --- a/bitbake/lib/bb/data.py
> +++ b/bitbake/lib/bb/data.py
> @@ -238,6 +238,7 @@ def emit_var(var, o=sys.__stdout__, d = init(), all=False):
>      # to a shell, we need to escape the quotes in the var
>      alter = re.sub('"', '\\"', val)
>      alter = re.sub('\n', ' \\\n', alter)
> +    alter = re.sub('\\$', '\\\\$', alter)
>      o.write('%s="%s"\n' % (varExpanded, alter))
>      return 0
>  
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com


WARNING: multiple messages have this Message-ID (diff)
From: Martin Jansa <martin.jansa@gmail.com>
To: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
Cc: openembedded-core@openembedded.org, bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [PATCH 1/1] [daisy][dizzy] data.py: fixes bad substitution when running devshell
Date: Fri, 17 Apr 2015 02:31:50 +0200	[thread overview]
Message-ID: <20150417003150.GC2341@jama> (raw)
In-Reply-To: <1428610909-12661-2-git-send-email-alejandro.hernandez@linux.intel.com>

On Thu, Apr 09, 2015 at 03:21:49PM -0500, Alejandro Hernandez wrote:
> From: Richard Tollerton <rich.tollerton@ni.com>
> 
> Running bitbake inside make results in the exported environment variable
> MAKEOVERRIDES="${-*-command-variables-*-}", which the shell chokes on
> when trying to expand it. But of course, it probably shouldn't have been
> trying to expand it in the first place -- so just escape the dollar
> sign.
> 
> (Bitbake rev: 18cd0ce6a55c9065c3f1bf223b47d817b5efcd8f)

This was already cherry-picked to 1.24 where it IIRC breaks powertop
build with current oe-core/dizzy.

Please backport:

commit a3e9b391e1024d6d2e256b75c214d34e6693e332
Author: Martin Jansa <martin.jansa@gmail.com>
Date:   Thu Dec 18 15:54:14 2014 +0100

    powertop: Fix build for !uclibc
    
    * EXTRA_LDFLAGS isn't defined for !uclibc and configure fails
      when it reads it unexpanded, see config.log snippet:

to unblock Dizzy builds and backport the same to Dylan before merging
this to 2.22.

> 
> Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
> 
> ---
>  bitbake/lib/bb/data.py | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/bitbake/lib/bb/data.py b/bitbake/lib/bb/data.py
> index eb628c7..82eefef 100644
> --- a/bitbake/lib/bb/data.py
> +++ b/bitbake/lib/bb/data.py
> @@ -238,6 +238,7 @@ def emit_var(var, o=sys.__stdout__, d = init(), all=False):
>      # to a shell, we need to escape the quotes in the var
>      alter = re.sub('"', '\\"', val)
>      alter = re.sub('\n', ' \\\n', alter)
> +    alter = re.sub('\\$', '\\\\$', alter)
>      o.write('%s="%s"\n' % (varExpanded, alter))
>      return 0
>  
> -- 
> 1.9.1
> 
> -- 
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com


  reply	other threads:[~2015-04-17  0:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-09 20:21 [PATCH 0/1] [daisy][dizzy] data.py: fixes bad substitution when running devshell Alejandro Hernandez
2015-04-09 20:21 ` [PATCH 1/1] " Alejandro Hernandez
2015-04-17  0:31   ` Martin Jansa [this message]
2015-04-17  0:31     ` [bitbake-devel] " Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150417003150.GC2341@jama \
    --to=martin.jansa@gmail.com \
    --cc=alejandro.hernandez@linux.intel.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=openembedded-core@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.