From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org, jamal <hadi@cyberus.ca>
Subject: Re: act_mirred: Fix bogus header when redirecting from VLAN
Date: Thu, 16 Apr 2015 18:34:02 -0700 [thread overview]
Message-ID: <20150417013401.GA4335@Alexeis-MacBook-Pro.local> (raw)
In-Reply-To: <20150417010216.GA22415@gondor.apana.org.au>
On Fri, Apr 17, 2015 at 09:02:16AM +0800, Herbert Xu wrote:
> @@ -105,7 +105,7 @@ static void ri_tasklet(unsigned long dev)
> if (from & AT_EGRESS) {
> dev_queue_xmit(skb);
> } else if (from & AT_INGRESS) {
> - skb_pull(skb, skb->dev->hard_header_len);
> + skb_pull(skb, _dev->hard_header_len);
...
> if (!(at & AT_EGRESS)) {
> if (m->tcfm_ok_push)
> - skb_push(skb2, skb2->dev->hard_header_len);
> + skb_push(skb2, dev->hard_header_len);
seems the cleaner fix will be to push skb->mac_len instead?
next prev parent reply other threads:[~2015-04-17 1:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 1:02 act_mirred: Fix bogus header when redirecting from VLAN Herbert Xu
2015-04-17 1:34 ` Alexei Starovoitov [this message]
2015-04-17 2:15 ` Herbert Xu
2015-04-17 2:40 ` Alexei Starovoitov
2015-04-17 5:32 ` [v2] " Herbert Xu
2015-04-17 15:26 ` Alexei Starovoitov
2015-04-17 17:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417013401.GA4335@Alexeis-MacBook-Pro.local \
--to=alexei.starovoitov@gmail.com \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.