From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: netdev@vger.kernel.org, jamal <hadi@cyberus.ca>
Subject: Re: [v2] act_mirred: Fix bogus header when redirecting from VLAN
Date: Fri, 17 Apr 2015 08:26:52 -0700 [thread overview]
Message-ID: <20150417152651.GA6965@Alexeis-MBP.westell.com> (raw)
In-Reply-To: <20150417053209.GA23855@gondor.apana.org.au>
On Fri, Apr 17, 2015 at 01:32:09PM +0800, Herbert Xu wrote:
> When you redirect a VLAN device to any device, you end up with
> crap in af_packet on the xmit path because hard_header_len is
> not equal to skb->mac_len. So the redirected packet contains
> four extra bytes at the start which then gets interpreted as
> part of the MAC address.
>
> This patch fixes this by only pushing skb->mac_len. We also
> need to fix ifb because it tries to undo the pushing done by
> act_mirred.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Alexei Starovoitov <ast@plumgrid.com>
next prev parent reply other threads:[~2015-04-17 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 1:02 act_mirred: Fix bogus header when redirecting from VLAN Herbert Xu
2015-04-17 1:34 ` Alexei Starovoitov
2015-04-17 2:15 ` Herbert Xu
2015-04-17 2:40 ` Alexei Starovoitov
2015-04-17 5:32 ` [v2] " Herbert Xu
2015-04-17 15:26 ` Alexei Starovoitov [this message]
2015-04-17 17:29 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417152651.GA6965@Alexeis-MBP.westell.com \
--to=alexei.starovoitov@gmail.com \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.