From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Added linux drivers backports project
Date: Fri, 17 Apr 2015 11:03:38 +0200 [thread overview]
Message-ID: <20150417090337.GA27179@vorel-pc> (raw)
In-Reply-To: <55301BBB.4090705@mind.be>
Thanks for comments, I'll create new version tonight.
> I would say that this package fits better in the linux extensions menu. Even if
> you just consider this package as a set of kernel modules, I think that from a
> users perspective it fits better together with the kernel.
Sounds reasonable, I'll do it.
> But also, if you ever
> want to add the possibility to link the backported drivers in the kernel itself
> (which I believe is supported by backports), then you really need it to be a
> kernel extension.
Not sure, I have to explore it.
> > +LINUX_BACKPORTS_VERSION = 3.19-rc1
> We prefer "stable" versions rather than rc's.
Ok, let it be 3.18.1. I just find 3.19-rc1 on
http://drvbp1.linux-foundation.org/~mcgrof/rel-html/backports/ (Temporary backports
release page, linked from homepage), I considered it as stable enough.
> LINUX_MAKE_FLAGS are normally passed as arguments to make. So I'd remove
I do probably something wrong: content of $(LINUX_MAKE_FLAGS) aren't added, so at least
CROSS_COMPILE is missing. But That's for $(kconfig-package). It might not be needed for
linux extension.
> TARGET_MAKE_ENV from LINUX_BACKPORTS_MAKE_FLAGS and turn the make commands into
> $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_FLAGS) \
> ...
Ok.
> Replace with $(kconfig-package), remove all the following and just set
> LINUX_BACKPORTS_KCONFIG_EDITORS and LINUX_BACKPORTS_KCONFIG_FILE.
> > +# Checks to give errors that the user can understand
> > +ifeq ($(filter source,$(MAKECMDGOALS)),)
> > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_DEFCONFIG),y)
> > +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG)),)
> > +$(error No kernel defconfig name specified, check your BR2_PACKAGE_LINUX_BACKPORTS_DEFCONFIG setting)
> > +endif
> > +endif
> > +
> > +ifeq ($(BR2_PACKAGE_LINUX_BACKPORTS_USE_CUSTOM_CONFIG),y)
> > +ifeq ($(call qstrip,$(BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE)),)
> > +$(error No kernel configuration file specified, check your BR2_PACKAGE_LINUX_BACKPORTS_CUSTOM_CONFIG_FILE setting)
> > +endif
> > +endif
> > +
> > +endif
I'd keep the error messages as indication for user.
Kind regards,
Petr
next prev parent reply other threads:[~2015-04-17 9:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 21:55 [Buildroot] [PATCH 0/1] Added linux drivers backports project Petr Vorel
2015-04-15 21:55 ` [Buildroot] [PATCH 1/1] " Petr Vorel
2015-04-16 20:29 ` Arnout Vandecappelle
2015-04-17 8:01 ` Thomas Petazzoni
2015-04-17 9:03 ` Petr Vorel [this message]
2015-04-17 9:14 ` Arnout Vandecappelle
-- strict thread matches above, loose matches on Subject: below --
2015-04-17 9:33 Petr Vorel
2015-04-17 9:33 ` Petr Vorel
2015-04-17 19:44 ` Arnout Vandecappelle
2015-04-17 9:40 Petr Vorel
2015-04-17 9:40 ` Petr Vorel
2015-04-17 19:35 ` Arnout Vandecappelle
2015-04-17 23:02 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417090337.GA27179@vorel-pc \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.