From: Petr Vorel <petr.vorel@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] Added linux drivers backports project
Date: Sat, 18 Apr 2015 01:02:45 +0200 [thread overview]
Message-ID: <20150417230243.GB3800@t61> (raw)
In-Reply-To: <55316095.5090902@mind.be>
> In the future, please give your patch a version number (by giving the argument
> -v3 or --subject-prefix='PATCH v3' to git send-email or format-patch). Also
> include a changelog below your SoB, separated by --- (you can do this while
> amending your commit).
Fixed, hope it's correct this time. Sent as -v4.
> Actually, kconfig-package should probably do a default assignment for
> LINUX_BACKPORTS_MAKE_ENV, but since it doesn't you have to do it explicitly.
I need LINUX_BACKPORTS_MAKE_ENV, as KLIB and KLIB_BUILD aren't set.
> However, ince below you're calling modules_install directly, would it be
> possible/reasonable to do the build in the same way? It's always nice if the
> different CMDS definitions look the same. So
> $(LINUX_BACKPORTS_MAKE_ENV) $(MAKE) $(LINUX_BACKPORTS_MAKE_OPTS) \
> -C $(LINUX_DIR) M=$(@D) \
> modules
> But if the backports build system does some extra magic (NOT kconfig stuff, but
> other magic), then of course you shouldn't do this.
Unfortunately it has to be build this way (or I haven't found any better).
LINUX_BACKPORTS_BUILD_CMDS needs -C $(@D), otherwise there is infinite loop. I'm
surprised, as $(@D) is backport directory (I'd expect to be add automatically) - suppose I
have an error somewhere.
LINUX_BACKPORTS_INSTALL_TARGET_CMDS needs -C $(LINUX_DIR) M=$(@D)
=> different commands.
> No nconfig? Not that it matters much...
Taken from busybox where it wasn't (sent as separate patch). Added...
BTW: I'd expect to have one unique default variable for all of those.
Kind regards,
Petr
next prev parent reply other threads:[~2015-04-17 23:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 9:40 [Buildroot] [PATCH 1/1] Added linux drivers backports project Petr Vorel
2015-04-17 9:40 ` Petr Vorel
2015-04-17 19:35 ` Arnout Vandecappelle
2015-04-17 23:02 ` Petr Vorel [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-04-17 9:33 Petr Vorel
2015-04-17 9:33 ` Petr Vorel
2015-04-17 19:44 ` Arnout Vandecappelle
2015-04-15 21:55 [Buildroot] [PATCH 0/1] " Petr Vorel
2015-04-15 21:55 ` [Buildroot] [PATCH 1/1] " Petr Vorel
2015-04-16 20:29 ` Arnout Vandecappelle
2015-04-17 8:01 ` Thomas Petazzoni
2015-04-17 9:03 ` Petr Vorel
2015-04-17 9:14 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150417230243.GB3800@t61 \
--to=petr.vorel@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.