From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/2] tee: generic TEE subsystem
Date: Sat, 18 Apr 2015 10:55:50 +0200 [thread overview]
Message-ID: <20150418085550.GA29858@kroah.com> (raw)
In-Reply-To: <1429257057-7935-2-git-send-email-jens.wiklander@linaro.org>
On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote:
> +/**
> + * struct tee_cmd_data - Opaque command argument
> + * @buf_ptr: [in] A __user pointer to a command buffer
> + * @buf_len: [in] Length of the buffer above
> + *
> + * Opaque command data which is passed on to the specific driver. The command
> + * buffer doesn't have to reside in shared memory.
> + * Used as argument for TEE_IOC_CMD below.
> + */
> +struct tee_ioctl_cmd_data {
> + uint64_t buf_ptr;
> + uint64_t buf_len;
> +};
All structures that cross the user/kernel boundry must use the __
variant of variable names. So for this one, it must be __u64.
Same for all of your ioctl structures.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Jens Wiklander <jens.wiklander@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>,
javier@javigon.com, Herbert Xu <herbert@gondor.apana.org.au>,
tpmdd-devel@lists.sourceforge.net, valentin.manea@huawei.com,
jean-michel.delorme@st.com, emmanuel.michel@st.com
Subject: Re: [RFC PATCH 1/2] tee: generic TEE subsystem
Date: Sat, 18 Apr 2015 10:55:50 +0200 [thread overview]
Message-ID: <20150418085550.GA29858@kroah.com> (raw)
In-Reply-To: <1429257057-7935-2-git-send-email-jens.wiklander@linaro.org>
On Fri, Apr 17, 2015 at 09:50:56AM +0200, Jens Wiklander wrote:
> +/**
> + * struct tee_cmd_data - Opaque command argument
> + * @buf_ptr: [in] A __user pointer to a command buffer
> + * @buf_len: [in] Length of the buffer above
> + *
> + * Opaque command data which is passed on to the specific driver. The command
> + * buffer doesn't have to reside in shared memory.
> + * Used as argument for TEE_IOC_CMD below.
> + */
> +struct tee_ioctl_cmd_data {
> + uint64_t buf_ptr;
> + uint64_t buf_len;
> +};
All structures that cross the user/kernel boundry must use the __
variant of variable names. So for this one, it must be __u64.
Same for all of your ioctl structures.
thanks,
greg k-h
next prev parent reply other threads:[~2015-04-18 8:55 UTC|newest]
Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 7:50 [RFC PATCH 0/2] generic TEE subsystem Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-17 7:50 ` [RFC PATCH 1/2] tee: " Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-17 16:30 ` [tpmdd-devel] " Jason Gunthorpe
2015-04-17 16:30 ` Jason Gunthorpe
2015-04-18 9:01 ` Russell King - ARM Linux
2015-04-18 9:01 ` Russell King - ARM Linux
2015-04-18 9:01 ` Russell King - ARM Linux
2015-04-18 17:29 ` Jason Gunthorpe
2015-04-18 17:29 ` Jason Gunthorpe
2015-04-18 17:29 ` Jason Gunthorpe
2015-04-18 21:57 ` Russell King - ARM Linux
2015-04-18 21:57 ` Russell King - ARM Linux
2015-04-18 21:57 ` Russell King - ARM Linux
2015-04-20 5:08 ` Jason Gunthorpe
2015-04-20 5:08 ` Jason Gunthorpe
2015-04-20 14:54 ` Greg Kroah-Hartman
2015-04-20 14:54 ` Greg Kroah-Hartman
2015-04-20 15:56 ` Jason Gunthorpe
2015-04-20 15:56 ` Jason Gunthorpe
2015-04-20 15:56 ` Jason Gunthorpe
2015-04-20 16:05 ` Greg Kroah-Hartman
2015-04-20 16:05 ` Greg Kroah-Hartman
2015-04-20 16:05 ` Greg Kroah-Hartman
2015-04-20 13:02 ` Jens Wiklander
2015-04-20 13:02 ` Jens Wiklander
2015-04-20 13:02 ` Jens Wiklander
2015-04-20 17:55 ` Jason Gunthorpe
2015-04-20 17:55 ` Jason Gunthorpe
2015-04-20 17:55 ` Jason Gunthorpe
2015-04-21 5:59 ` Jens Wiklander
2015-04-21 5:59 ` Jens Wiklander
2015-04-17 20:07 ` Arnd Bergmann
2015-04-17 20:07 ` Arnd Bergmann
2015-04-18 7:20 ` Paul Bolle
2015-04-18 7:20 ` Paul Bolle
2015-04-18 7:20 ` Paul Bolle
2015-04-20 6:20 ` Jens Wiklander
2015-04-20 6:20 ` Jens Wiklander
2015-04-20 18:20 ` [tpmdd-devel] " Jason Gunthorpe
2015-04-20 18:20 ` Jason Gunthorpe
2015-04-21 10:45 ` Jens Wiklander
2015-04-21 10:45 ` Jens Wiklander
2015-04-18 8:55 ` Greg Kroah-Hartman [this message]
2015-04-18 8:55 ` Greg Kroah-Hartman
2015-04-18 8:57 ` Greg Kroah-Hartman
2015-04-18 8:57 ` Greg Kroah-Hartman
2015-04-18 9:04 ` Russell King - ARM Linux
2015-04-18 9:04 ` Russell King - ARM Linux
2015-04-18 9:04 ` Russell King - ARM Linux
2015-04-18 18:47 ` Greg Kroah-Hartman
2015-04-18 18:47 ` Greg Kroah-Hartman
2015-04-18 19:02 ` Russell King - ARM Linux
2015-04-18 19:02 ` Russell King - ARM Linux
2015-04-18 20:37 ` Greg Kroah-Hartman
2015-04-18 20:37 ` Greg Kroah-Hartman
2015-04-18 20:50 ` Russell King - ARM Linux
2015-04-18 20:50 ` Russell King - ARM Linux
2015-04-19 7:00 ` Greg Kroah-Hartman
2015-04-19 7:00 ` Greg Kroah-Hartman
2015-04-17 7:50 ` [RFC PATCH 2/2] tee: add OP-TEE driver Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-17 7:50 ` Jens Wiklander
2015-04-18 8:57 ` Greg Kroah-Hartman
2015-04-18 8:57 ` Greg Kroah-Hartman
2015-04-18 9:36 ` Javier González
2015-04-18 9:36 ` Javier González
2015-04-18 9:36 ` Javier González
2015-04-18 18:49 ` Greg Kroah-Hartman
2015-04-18 18:49 ` Greg Kroah-Hartman
2015-04-18 19:01 ` Arnd Bergmann
2015-04-18 19:01 ` Arnd Bergmann
2015-04-19 11:17 ` Javier González
2015-04-19 11:17 ` Javier González
2015-04-19 19:47 ` Arnd Bergmann
2015-04-19 19:47 ` Arnd Bergmann
2015-04-20 7:05 ` Javier González
2015-04-20 7:05 ` Javier González
2015-04-20 7:05 ` Javier González
2015-04-20 6:42 ` Jens Wiklander
2015-04-20 6:42 ` Jens Wiklander
2015-04-20 6:42 ` Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150418085550.GA29858@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.