From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Implement 1-,2- byte smp_load_acquire and smp_store_release
Date: Mon, 20 Apr 2015 17:13:57 +0100 [thread overview]
Message-ID: <20150420161357.GE1504@arm.com> (raw)
In-Reply-To: <CA+55aFwgG0pNwp3ywOsaEfeArD43MoJ9VLbUYQ8DCKN30=mLOA@mail.gmail.com>
On Mon, Apr 20, 2015 at 05:08:37PM +0100, Linus Torvalds wrote:
> On Mon, Apr 20, 2015 at 8:45 AM, Andrey Ryabinin <a.ryabinin@samsung.com> wrote:
> >
> > Commit 8053871d0f7f ("smp: Fix smp_call_function_single_async() locking")
> > started to use smp_load_acquire() to load 2-bytes csd->flags.
> > That crashes arm64 kernel during the boot.
>
> Ahh. I don't disagree with your patch, but we should just make
> csd->flags be an "int" regardless of this issue.
>
> There is absolutely no reason to try to use 16-bit words. It doesn't
> save us any space (alignment), and it's just a *bad* idea to depend on
> any kind of atomicity of 16-bit entities. Bytes, yes. Words, yes. But
> 16-bit half-words? There's no point.
>
> So I'll make it "unsigned int" instead of "u16".
>
> But as said, the ARM64 patch definitely is a good idea regardless.
Sounds good to me and means I can leave the pull for a day or two to see
if any other arm64 fixes queue up.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrey Ryabinin <a.ryabinin@samsung.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: Implement 1-,2- byte smp_load_acquire and smp_store_release
Date: Mon, 20 Apr 2015 17:13:57 +0100 [thread overview]
Message-ID: <20150420161357.GE1504@arm.com> (raw)
In-Reply-To: <CA+55aFwgG0pNwp3ywOsaEfeArD43MoJ9VLbUYQ8DCKN30=mLOA@mail.gmail.com>
On Mon, Apr 20, 2015 at 05:08:37PM +0100, Linus Torvalds wrote:
> On Mon, Apr 20, 2015 at 8:45 AM, Andrey Ryabinin <a.ryabinin@samsung.com> wrote:
> >
> > Commit 8053871d0f7f ("smp: Fix smp_call_function_single_async() locking")
> > started to use smp_load_acquire() to load 2-bytes csd->flags.
> > That crashes arm64 kernel during the boot.
>
> Ahh. I don't disagree with your patch, but we should just make
> csd->flags be an "int" regardless of this issue.
>
> There is absolutely no reason to try to use 16-bit words. It doesn't
> save us any space (alignment), and it's just a *bad* idea to depend on
> any kind of atomicity of 16-bit entities. Bytes, yes. Words, yes. But
> 16-bit half-words? There's no point.
>
> So I'll make it "unsigned int" instead of "u16".
>
> But as said, the ARM64 patch definitely is a good idea regardless.
Sounds good to me and means I can leave the pull for a day or two to see
if any other arm64 fixes queue up.
Will
next prev parent reply other threads:[~2015-04-20 16:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 15:45 [PATCH] arm64: Implement 1-,2- byte smp_load_acquire and smp_store_release Andrey Ryabinin
2015-04-20 15:45 ` Andrey Ryabinin
2015-04-20 15:48 ` Will Deacon
2015-04-20 15:48 ` Will Deacon
2015-04-20 16:09 ` Paul E. McKenney
2015-04-20 16:09 ` Paul E. McKenney
2015-04-20 16:08 ` [PATCH] arm64: Implement 1-, 2- " Linus Torvalds
2015-04-20 16:08 ` [PATCH] arm64: Implement 1-,2- " Linus Torvalds
2015-04-20 16:13 ` Will Deacon [this message]
2015-04-20 16:13 ` Will Deacon
2015-04-20 16:08 ` Paul E. McKenney
2015-04-20 16:08 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150420161357.GE1504@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.