[PATCH] ltp-ddt: Skip mv of kernel files if no files found

[PATCH] ltp-ddt: Skip mv of kernel files if no files found

[Sam Nelson]

- Install was failing if there are no modules for certain platforms

Signed-off-by: Sam Nelson <sam.nelson@ti.com>
---
 .../recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb      |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb b/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
index 68e1a3c..609b344 100644
--- a/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
+++ b/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
@@ -87,7 +87,7 @@ do_install() {
     oe_runmake install
     install -d ${D}${datadir}
     install -d ${D}${kmoddir}
-    mv ${D}${LTPROOT}/testcases/bin/ddt/*.ko ${D}${kmoddir}
+    find ${D}${LTPROOT}/testcases/bin/ddt/*.ko && mv ${D}${LTPROOT}/testcases/bin/ddt/*.ko ${D}${kmoddir}
 }
 
 # do_make_scripts should be a separate task for the lock to work
-- 
1.7.9.5

Re: [PATCH] ltp-ddt: Skip mv of kernel files if no files found

[Denys Dmytriyenko]

On Fri, Apr 17, 2015 at 04:25:46PM -0400, Sam Nelson wrote:
> - Install was failing if there are no modules for certain platforms
> 
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
>  .../recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb      |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb b/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
> index 68e1a3c..609b344 100644
> --- a/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
> +++ b/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
> @@ -87,7 +87,7 @@ do_install() {
>      oe_runmake install
>      install -d ${D}${datadir}
>      install -d ${D}${kmoddir}
> -    mv ${D}${LTPROOT}/testcases/bin/ddt/*.ko ${D}${kmoddir}
> +    find ${D}${LTPROOT}/testcases/bin/ddt/*.ko && mv ${D}${LTPROOT}/testcases/bin/ddt/*.ko ${D}${kmoddir}

Should probably do "mv || true" instead...


>  }
>  
>  # do_make_scripts should be a separate task for the lock to work
> -- 
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] ltp-ddt: Skip mv of kernel files if no files found

[Denys Dmytriyenko]

On Mon, Apr 20, 2015 at 02:41:21PM -0400, Denys Dmytriyenko wrote:
> On Fri, Apr 17, 2015 at 04:25:46PM -0400, Sam Nelson wrote:
> > - Install was failing if there are no modules for certain platforms
> > 
> > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > ---
> >  .../recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb      |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb b/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
> > index 68e1a3c..609b344 100644
> > --- a/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
> > +++ b/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
> > @@ -87,7 +87,7 @@ do_install() {
> >      oe_runmake install
> >      install -d ${D}${datadir}
> >      install -d ${D}${kmoddir}
> > -    mv ${D}${LTPROOT}/testcases/bin/ddt/*.ko ${D}${kmoddir}
> > +    find ${D}${LTPROOT}/testcases/bin/ddt/*.ko && mv ${D}${LTPROOT}/testcases/bin/ddt/*.ko ${D}${kmoddir}
> 
> Should probably do "mv || true" instead...

Sam,

Do you have any issues doing mv||true construct or do you want to stick with 
the find command for any reason?

-- 
Denys

Re: [PATCH] ltp-ddt: Skip mv of kernel files if no files found

[Nelson, Sam]

> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Wednesday, April 22, 2015 3:15 PM
> To: Nelson, Sam
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] ltp-ddt: Skip mv of kernel files if no files
> found
> 
> On Mon, Apr 20, 2015 at 02:41:21PM -0400, Denys Dmytriyenko wrote:
> > On Fri, Apr 17, 2015 at 04:25:46PM -0400, Sam Nelson wrote:
> > > - Install was failing if there are no modules for certain platforms
> > >
> > > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > > ---
> > >  .../recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb      |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
> > > b/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
> > > index 68e1a3c..609b344 100644
> > > --- a/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
> > > +++ b/meta-arago-extras/recipes-devtools/ltp-ddt/ltp-ddt_1.0.0.bb
> > > @@ -87,7 +87,7 @@ do_install() {
> > >      oe_runmake install
> > >      install -d ${D}${datadir}
> > >      install -d ${D}${kmoddir}
> > > -    mv ${D}${LTPROOT}/testcases/bin/ddt/*.ko ${D}${kmoddir}
> > > +    find ${D}${LTPROOT}/testcases/bin/ddt/*.ko && mv
> > > + ${D}${LTPROOT}/testcases/bin/ddt/*.ko ${D}${kmoddir}
> >
> > Should probably do "mv || true" instead...
> 
> Sam,
> 
> Do you have any issues doing mv||true construct or do you want to stick
> with the find command for any reason?
I am fine with this. Thanks.
> 
> --
> Denys