From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91/dt: kizbox: update and rename to at91-kizbox
Date: Tue, 21 Apr 2015 09:11:00 +0200 [thread overview]
Message-ID: <20150421091100.6bb8ba36@bbrezillon> (raw)
In-Reply-To: <1429521218-9752-1-git-send-email-g.portay@overkiz.com>
Hi Gael,
On Mon, 20 Apr 2015 11:13:38 +0200
Ga?l PORTAY <g.portay@overkiz.com> wrote:
> Sort nodes, rename to match Atmel naming convention
You should use -M when you generate your patches with format-patch: it
keeps track of files that have been renamed instead of considering it
as a removal + an addition.
> and update the features
> below:
> - command-line,
> - use proper serial uart,
> - rename leds and gpio-keys,
> - update to pwm-leds and
> - fix gpio-key level.
Please split this patch so we can easily review the changes.
How about the following separation ?
- rename dts file
- use stdout-path
- sanitize bootargs
- led related changes (rename + pwm-leds)
- gpio-key related changes (rename + fix level)
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: "Gaël PORTAY" <g.portay@overkiz.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: at91/dt: kizbox: update and rename to at91-kizbox
Date: Tue, 21 Apr 2015 09:11:00 +0200 [thread overview]
Message-ID: <20150421091100.6bb8ba36@bbrezillon> (raw)
In-Reply-To: <1429521218-9752-1-git-send-email-g.portay@overkiz.com>
Hi Gael,
On Mon, 20 Apr 2015 11:13:38 +0200
Gaël PORTAY <g.portay@overkiz.com> wrote:
> Sort nodes, rename to match Atmel naming convention
You should use -M when you generate your patches with format-patch: it
keeps track of files that have been renamed instead of considering it
as a removal + an addition.
> and update the features
> below:
> - command-line,
> - use proper serial uart,
> - rename leds and gpio-keys,
> - update to pwm-leds and
> - fix gpio-key level.
Please split this patch so we can easily review the changes.
How about the following separation ?
- rename dts file
- use stdout-path
- sanitize bootargs
- led related changes (rename + pwm-leds)
- gpio-key related changes (rename + fix level)
Best Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-04-21 7:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 9:13 [PATCH] ARM: at91/dt: kizbox: update and rename to at91-kizbox Gaël PORTAY
2015-04-20 9:13 ` Gaël PORTAY
2015-04-21 7:11 ` Boris Brezillon [this message]
2015-04-21 7:11 ` Boris Brezillon
2015-04-21 10:03 ` Gaël PORTAY
2015-04-21 10:03 ` Gaël PORTAY
2015-04-21 10:08 ` Boris Brezillon
2015-04-21 10:08 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150421091100.6bb8ba36@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.