From: Al Viro <viro@ZenIV.linux.org.uk>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-kernel@vger.kernel.org, j@w1.fi,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] fs/9p: fix readdir()
Date: Wed, 22 Apr 2015 14:43:06 +0100 [thread overview]
Message-ID: <20150422134306.GV889@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1429696514-14779-1-git-send-email-johannes@sipsolutions.net>
On Wed, Apr 22, 2015 at 11:55:14AM +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> Al Viro's IOV changes broke 9p readdir() because the new code
> didn't abort the read when it returned nothing. The original
> code checked if the combined error/length was <= 0 but in the
> new code that accidentally got changed to just an error check.
>
> Add back the return from the function when nothing is read.
Nice catch... FWIW, this hadn't been caught since it doesn't trigger
on 9P.L tests. Applied, and testing setup fixed.
prev parent reply other threads:[~2015-04-22 13:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 9:55 [PATCH] fs/9p: fix readdir() Johannes Berg
2015-04-22 13:43 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150422134306.GV889@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=j@w1.fi \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.