* [PATCH 2/2 infiniband-diags] ibqueryerrors: Resource leak in path_record_query
@ 2015-04-21 12:15 Hal Rosenstock
[not found] ` <55363F50.3050905-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Hal Rosenstock @ 2015-04-21 12:15 UTC (permalink / raw)
To: Ira Weiny
Cc: Vladimir Koushnir,
linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
From: Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Date: Thu Apr 16 16:39:43 2015 +0300
sa_free_handle function is not called at the end of
path_record_query function.
The patch fixes file descriptor leak when path_record_query
function is called.
Signed-off-by: Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
src/ibqueryerrors.c | 34 +++++++++++++++++++++++++++-------
1 files changed, 27 insertions(+), 7 deletions(-)
diff --git a/src/ibqueryerrors.c b/src/ibqueryerrors.c
index 9d9ec45..8fbb9d1 100644
--- a/src/ibqueryerrors.c
+++ b/src/ibqueryerrors.c
@@ -344,6 +344,7 @@ static int path_record_query(ib_gid_t sgid,uint64_t dguid)
(uint16_t)IB_SA_ATTR_PATHRECORD,0,cl_ntoh64(comp_mask),ibd_sakey,
&pr, sizeof(pr), &result);
if (ret) {
+ sa_free_handle(h);
fprintf(stderr, "Query SA failed: %s; sa call path_query failed\n", strerror(ret));
return ret;
}
@@ -355,6 +356,7 @@ static int path_record_query(ib_gid_t sgid,uint64_t dguid)
insert_lid2sl_table(&result);
Exit:
+ sa_free_handle(h);
sa_free_result_mad(&result);
return ret;
}
--
1.7.8.2
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2 infiniband-diags] ibqueryerrors: Resource leak in path_record_query
[not found] ` <55363F50.3050905-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
@ 2015-04-22 14:56 ` ira.weiny
2015-04-22 14:57 ` ira.weiny
1 sibling, 0 replies; 3+ messages in thread
From: ira.weiny @ 2015-04-22 14:56 UTC (permalink / raw)
To: Hal Rosenstock
Cc: Vladimir Koushnir,
linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
On Tue, Apr 21, 2015 at 08:15:12AM -0400, Hal Rosenstock wrote:
> From: Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Date: Thu Apr 16 16:39:43 2015 +0300
>
> sa_free_handle function is not called at the end of
> path_record_query function.
> The patch fixes file descriptor leak when path_record_query
> function is called.
>
> Signed-off-by: Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Applied Thanks,
Ira
>
> ---
> src/ibqueryerrors.c | 34 +++++++++++++++++++++++++++-------
> 1 files changed, 27 insertions(+), 7 deletions(-)
>
> diff --git a/src/ibqueryerrors.c b/src/ibqueryerrors.c
> index 9d9ec45..8fbb9d1 100644
> --- a/src/ibqueryerrors.c
> +++ b/src/ibqueryerrors.c
> @@ -344,6 +344,7 @@ static int path_record_query(ib_gid_t sgid,uint64_t dguid)
> (uint16_t)IB_SA_ATTR_PATHRECORD,0,cl_ntoh64(comp_mask),ibd_sakey,
> &pr, sizeof(pr), &result);
> if (ret) {
> + sa_free_handle(h);
> fprintf(stderr, "Query SA failed: %s; sa call path_query failed\n", strerror(ret));
> return ret;
> }
> @@ -355,6 +356,7 @@ static int path_record_query(ib_gid_t sgid,uint64_t dguid)
>
> insert_lid2sl_table(&result);
> Exit:
> + sa_free_handle(h);
> sa_free_result_mad(&result);
> return ret;
> }
> --
> 1.7.8.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/2 infiniband-diags] ibqueryerrors: Resource leak in path_record_query
[not found] ` <55363F50.3050905-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-04-22 14:56 ` ira.weiny
@ 2015-04-22 14:57 ` ira.weiny
1 sibling, 0 replies; 3+ messages in thread
From: ira.weiny @ 2015-04-22 14:57 UTC (permalink / raw)
To: Hal Rosenstock
Cc: Vladimir Koushnir,
linux-rdma (linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org)
On Tue, Apr 21, 2015 at 08:15:12AM -0400, Hal Rosenstock wrote:
> From: Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Date: Thu Apr 16 16:39:43 2015 +0300
>
> sa_free_handle function is not called at the end of
> path_record_query function.
> The patch fixes file descriptor leak when path_record_query
> function is called.
>
> Signed-off-by: Vladimir Koushnir <vladimirk-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Applied Thanks,
Ira
> ---
> src/ibqueryerrors.c | 34 +++++++++++++++++++++++++++-------
> 1 files changed, 27 insertions(+), 7 deletions(-)
>
> diff --git a/src/ibqueryerrors.c b/src/ibqueryerrors.c
> index 9d9ec45..8fbb9d1 100644
> --- a/src/ibqueryerrors.c
> +++ b/src/ibqueryerrors.c
> @@ -344,6 +344,7 @@ static int path_record_query(ib_gid_t sgid,uint64_t dguid)
> (uint16_t)IB_SA_ATTR_PATHRECORD,0,cl_ntoh64(comp_mask),ibd_sakey,
> &pr, sizeof(pr), &result);
> if (ret) {
> + sa_free_handle(h);
> fprintf(stderr, "Query SA failed: %s; sa call path_query failed\n", strerror(ret));
> return ret;
> }
> @@ -355,6 +356,7 @@ static int path_record_query(ib_gid_t sgid,uint64_t dguid)
>
> insert_lid2sl_table(&result);
> Exit:
> + sa_free_handle(h);
> sa_free_result_mad(&result);
> return ret;
> }
> --
> 1.7.8.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-22 14:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-21 12:15 [PATCH 2/2 infiniband-diags] ibqueryerrors: Resource leak in path_record_query Hal Rosenstock
[not found] ` <55363F50.3050905-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-04-22 14:56 ` ira.weiny
2015-04-22 14:57 ` ira.weiny
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.