From: Alexander Aring <alex.aring@gmail.com>
To: Christoffer Holmstedt <christoffer.holmstedt@gmail.com>
Cc: linux-wpan@vger.kernel.org
Subject: Re: First kernel patch - checkpatch for at86rf230.c, false-positives?
Date: Thu, 23 Apr 2015 13:15:54 +0200 [thread overview]
Message-ID: <20150423111553.GB9284@omega> (raw)
In-Reply-To: <CAG9Fz+usxJ-9ME2VoODfO1W2usMophATuYD5Nxer_w9TXj9Rag@mail.gmail.com>
On Thu, Apr 23, 2015 at 12:25:34PM +0200, Christoffer Holmstedt wrote:
...
>
> Thank you Alexander for your fast and thorough response, I expected
> something like that as other defines did have parantheses.
>
if you like to send a first patch, maybe to "breaking the ice". Then I
see several cleanups there, like I used some magic values for masking
the trac status or trx state e.g. "trx_state = buf[1] & 0x1f;". You can
introduce some macro for that and replacing it where it used.
Or simple sending some patches for whatever you want, I/community will review
them.
With "breaking the ice", I mean some "testing linux send patch
environment" and getting familiar with sending patches. When it is your
first time.
- Alex
next prev parent reply other threads:[~2015-04-23 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 9:48 First kernel patch - checkpatch for at86rf230.c, false-positives? Christoffer Holmstedt
2015-04-23 10:09 ` Alexander Aring
2015-04-23 10:25 ` Christoffer Holmstedt
2015-04-23 11:15 ` Alexander Aring [this message]
2015-04-23 11:48 ` Christoffer Holmstedt
2015-04-23 12:08 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423111553.GB9284@omega \
--to=alex.aring@gmail.com \
--cc=christoffer.holmstedt@gmail.com \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.