Re: [PATCH v3 3/5] libxl: use LIBXL_TOOLSTACK_DOMID

[Wei Liu <wei.liu2@citrix.com>]

On Fri, Apr 24, 2015 at 10:49:36AM +0200, Olaf Hering wrote:
> On Fri, Mar 20, Wei Liu wrote:
> 
> > +++ b/tools/libxl/libxl_dm.c
> > @@ -1438,6 +1438,8 @@ retry_transaction:
> >  
> >      spawn->what = GCSPRINTF("domain %d device model", domid);
> >      spawn->xspath = GCSPRINTF("/local/domain/0/device-model/%d/state", domid);
> > +    spawn->xspath = libxl__device_model_xs_path(gc, LIBXL_TOOLSTACK_DOMID,
> > +                                                domid, "/state");
> 
> This assigns xspath twice.
> 

Good spot. I will send a patch to fix this. Luckily this doesn't cause
practical problem except for wasting some memory. :-)

Wei.

> Olaf