From: Ian Campbell <ian.campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org
Subject: Re: [PATCH v3 1/5] libxl: introduce libxl__device_model_xs_path
Date: Tue, 24 Mar 2015 14:32:42 +0000 [thread overview]
Message-ID: <1427207562.21742.406.camel@citrix.com> (raw)
In-Reply-To: <1426868353-31557-2-git-send-email-wei.liu2@citrix.com>
On Fri, 2015-03-20 at 16:19 +0000, Wei Liu wrote:
> +_hidden char *libxl__device_model_xs_path(libxl__gc *gc, uint32_t dm_domid,
> + uint32_t domid,
> + const char *format, ...);
This should have the PRINTF_ATTRIBUTE thing and not the double space
before "...".
With that fixed: Acked-by: Ian Campbell <ian.campbell@citrix.com>
Since this is pretty minor if you want to resend just this one patch, or
even send an incremental fixup to be folded in I can take care of it on
commit.
Ian.
next prev parent reply other threads:[~2015-03-24 14:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 16:19 [PATCH v3 0/5] Fix QEMU startup protocol Wei Liu
2015-03-20 16:19 ` [PATCH v3 1/5] libxl: introduce libxl__device_model_xs_path Wei Liu
2015-03-24 14:32 ` Ian Campbell [this message]
2015-03-24 14:49 ` Wei Liu
2015-03-24 16:53 ` Ian Campbell
2015-03-24 17:18 ` Ian Campbell
2015-03-20 16:19 ` [PATCH v3 2/5] libxl: remove device model path in libxl__device_model_destroy Wei Liu
2015-03-20 16:19 ` [PATCH v3 3/5] libxl: use LIBXL_TOOLSTACK_DOMID Wei Liu
2015-04-24 8:49 ` Olaf Hering
2015-04-24 8:57 ` Wei Liu
2015-03-20 16:19 ` [PATCH v3 4/5] libxl: use new QEMU xenstore protocol Wei Liu
2015-03-24 17:16 ` Ian Campbell
2015-03-20 16:19 ` [PATCH v3 5/5] Revert "x86/hvm: wait for at least one ioreq server to be enabled" Wei Liu
2015-03-20 16:43 ` Jan Beulich
2015-03-24 17:19 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427207562.21742.406.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.