From: Mel Gorman <mgorman@suse.de>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Linux-MM <linux-mm@kvack.org>, Rik van Riel <riel@redhat.com>,
Hugh Dickins <hughd@google.com>, Minchan Kim <minchan@kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/6] TLB flush multiple pages with a single IPI v3
Date: Fri, 24 Apr 2015 16:16:52 +0100 [thread overview]
Message-ID: <20150424151652.GC2449@suse.de> (raw)
In-Reply-To: <553A573E.2000608@suse.cz>
On Fri, Apr 24, 2015 at 04:46:22PM +0200, Vlastimil Babka wrote:
> On 04/21/2015 12:41 PM, Mel Gorman wrote:
> >Changelog since V2
> >o Ensure TLBs are flushed before pages are freed (mel)
>
> I admit not reading all the patches thoroughly, but doesn't this
> change of ordering mean that you no longer need the architectural
> guarantee discussed in patch 2?
No. If we unmap a page to write it to disk then we cannot allow a CPU to
write to the physical page being written through a cached entry.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@suse.de>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Linux-MM <linux-mm@kvack.org>, Rik van Riel <riel@redhat.com>,
Hugh Dickins <hughd@google.com>, Minchan Kim <minchan@kernel.org>,
Dave Hansen <dave.hansen@intel.com>,
Andi Kleen <andi@firstfloor.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/6] TLB flush multiple pages with a single IPI v3
Date: Fri, 24 Apr 2015 16:16:52 +0100 [thread overview]
Message-ID: <20150424151652.GC2449@suse.de> (raw)
In-Reply-To: <553A573E.2000608@suse.cz>
On Fri, Apr 24, 2015 at 04:46:22PM +0200, Vlastimil Babka wrote:
> On 04/21/2015 12:41 PM, Mel Gorman wrote:
> >Changelog since V2
> >o Ensure TLBs are flushed before pages are freed (mel)
>
> I admit not reading all the patches thoroughly, but doesn't this
> change of ordering mean that you no longer need the architectural
> guarantee discussed in patch 2?
No. If we unmap a page to write it to disk then we cannot allow a CPU to
write to the physical page being written through a cached entry.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2015-04-24 15:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 10:41 [RFC PATCH 0/6] TLB flush multiple pages with a single IPI v3 Mel Gorman
2015-04-21 10:41 ` Mel Gorman
2015-04-21 10:41 ` [PATCH 1/6] x86, mm: Trace when an IPI is about to be sent Mel Gorman
2015-04-21 10:41 ` Mel Gorman
2015-04-21 10:41 ` [PATCH 2/6] mm: Send a single IPI to TLB flush multiple pages when unmapping Mel Gorman
2015-04-21 10:41 ` Mel Gorman
2015-04-21 10:41 ` [PATCH 3/6] mm: Defer TLB flush after unmap as long as possible Mel Gorman
2015-04-21 10:41 ` Mel Gorman
2015-04-21 20:31 ` Rik van Riel
2015-04-21 20:31 ` Rik van Riel
2015-04-21 21:17 ` Mel Gorman
2015-04-21 21:17 ` Mel Gorman
2015-04-21 10:41 ` [PATCH 4/6] mm, migrate: Drop references to successfully migrated pages at the same time Mel Gorman
2015-04-21 10:41 ` Mel Gorman
2015-04-21 10:41 ` [PATCH 5/6] mm, migrate: Batch TLB flushing when unmapping pages for migration Mel Gorman
2015-04-21 10:41 ` Mel Gorman
2015-04-21 10:41 ` [PATCH 6/6] mm: Gather more PFNs before sending a TLB to flush unmapped pages Mel Gorman
2015-04-21 10:41 ` Mel Gorman
2015-04-24 14:46 ` [RFC PATCH 0/6] TLB flush multiple pages with a single IPI v3 Vlastimil Babka
2015-04-24 14:46 ` Vlastimil Babka
2015-04-24 15:16 ` Mel Gorman [this message]
2015-04-24 15:16 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150424151652.GC2449@suse.de \
--to=mgorman@suse.de \
--cc=andi@firstfloor.org \
--cc=dave.hansen@intel.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=riel@redhat.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.