[meta-oe][meta-systemd][PATCH V3 1/2] bluez4_4.101.bbappend: update according to bluez4

[meta-oe][meta-systemd][PATCH V3 1/2] bluez4_4.101.bbappend: update according to bluez4

[Cristian Iorga]

bluez4 recipe has been updated with proper systemd
support, so update meta-systemd append accordingly.
Also update to the right directory structure.

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
---
 .../recipes-connectivity/bluez/bluez4_4.101.bbappend                 | 5 -----
 1 file changed, 5 deletions(-)
 rename meta-systemd/{oe-core => meta-oe}/recipes-connectivity/bluez/bluez4_4.101.bbappend (51%)

diff --git a/meta-systemd/oe-core/recipes-connectivity/bluez/bluez4_4.101.bbappend b/meta-systemd/meta-oe/recipes-connectivity/bluez/bluez4_4.101.bbappend
similarity index 51%
rename from meta-systemd/oe-core/recipes-connectivity/bluez/bluez4_4.101.bbappend
rename to meta-systemd/meta-oe/recipes-connectivity/bluez/bluez4_4.101.bbappend
index da01b05..260c02e 100644
--- a/meta-systemd/oe-core/recipes-connectivity/bluez/bluez4_4.101.bbappend
+++ b/meta-systemd/meta-oe/recipes-connectivity/bluez/bluez4_4.101.bbappend
@@ -1,9 +1,4 @@
-inherit systemd
-
-EXTRA_OECONF += "--with-systemdunitdir=${systemd_unitdir}/system/"
-
 RPROVIDES_${PN} += "${PN}-systemd"
 RREPLACES_${PN} += "${PN}-systemd"
 RCONFLICTS_${PN} += "${PN}-systemd"
-SYSTEMD_SERVICE_${PN} = "bluetooth.service"
 SYSTEMD_AUTO_ENABLE = "disable"
-- 
2.1.0

[meta-oe][meta-systemd][PATCH V3 2/2] layer.conf: add detection of meta-oe layer.

[Cristian Iorga]

bluez append has been moved to meta-oe,
so add detection for that layer.

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
---
 meta-systemd/conf/layer.conf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-systemd/conf/layer.conf b/meta-systemd/conf/layer.conf
index 0563f44..06c2ff1 100644
--- a/meta-systemd/conf/layer.conf
+++ b/meta-systemd/conf/layer.conf
@@ -15,6 +15,7 @@ BBPATH .= ":${LAYERDIR}"
 BBFILES += "\
   ${LAYERDIR}/recipes-*/*/*.bb \
   ${LAYERDIR}/oe-core/recipes-*/*/*.bbappend \
+  ${LAYERDIR}/meta-oe/recipes-*/*/*.bbappend \
 "
 
 BBFILE_COLLECTIONS += "systemd-layer"
-- 
2.1.0

Re: [meta-oe][meta-systemd][PATCH V3 1/2] bluez4_4.101.bbappend: update according to bluez4

[Iorga, Cristian]

In V3, proper layer.conf for meta-systemd with meta-oe added detection.

-----Original Message-----
From: Iorga, Cristian 
Sent: Friday, April 24, 2015 6:44 PM
To: openembedded-devel@lists.openembedded.org
Cc: Iorga, Cristian
Subject: [meta-oe][meta-systemd][PATCH V3 1/2] bluez4_4.101.bbappend: update according to bluez4

bluez4 recipe has been updated with proper systemd support, so update meta-systemd append accordingly.
Also update to the right directory structure.

Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
---
 .../recipes-connectivity/bluez/bluez4_4.101.bbappend                 | 5 -----
 1 file changed, 5 deletions(-)
 rename meta-systemd/{oe-core => meta-oe}/recipes-connectivity/bluez/bluez4_4.101.bbappend (51%)

diff --git a/meta-systemd/oe-core/recipes-connectivity/bluez/bluez4_4.101.bbappend b/meta-systemd/meta-oe/recipes-connectivity/bluez/bluez4_4.101.bbappend
similarity index 51%
rename from meta-systemd/oe-core/recipes-connectivity/bluez/bluez4_4.101.bbappend
rename to meta-systemd/meta-oe/recipes-connectivity/bluez/bluez4_4.101.bbappend
index da01b05..260c02e 100644
--- a/meta-systemd/oe-core/recipes-connectivity/bluez/bluez4_4.101.bbappend
+++ b/meta-systemd/meta-oe/recipes-connectivity/bluez/bluez4_4.101.bbapp
+++ end
@@ -1,9 +1,4 @@
-inherit systemd
-
-EXTRA_OECONF += "--with-systemdunitdir=${systemd_unitdir}/system/"
-
 RPROVIDES_${PN} += "${PN}-systemd"
 RREPLACES_${PN} += "${PN}-systemd"
 RCONFLICTS_${PN} += "${PN}-systemd"
-SYSTEMD_SERVICE_${PN} = "bluetooth.service"
 SYSTEMD_AUTO_ENABLE = "disable"
--
2.1.0

Re: [meta-oe][meta-systemd][PATCH V3 2/2] layer.conf: add detection of meta-oe layer.

[Martin Jansa]

On Fri, Apr 24, 2015 at 06:43:52PM +0300, Cristian Iorga wrote:
> bluez append has been moved to meta-oe,
> so add detection for that layer.

This isn't "detection" :)

> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
>  meta-systemd/conf/layer.conf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta-systemd/conf/layer.conf b/meta-systemd/conf/layer.conf
> index 0563f44..06c2ff1 100644
> --- a/meta-systemd/conf/layer.conf
> +++ b/meta-systemd/conf/layer.conf
> @@ -15,6 +15,7 @@ BBPATH .= ":${LAYERDIR}"
>  BBFILES += "\
>    ${LAYERDIR}/recipes-*/*/*.bb \
>    ${LAYERDIR}/oe-core/recipes-*/*/*.bbappend \
> +  ${LAYERDIR}/meta-oe/recipes-*/*/*.bbappend \
>  "
>  
>  BBFILE_COLLECTIONS += "systemd-layer"
> -- 
> 2.1.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

Re: [meta-oe][meta-systemd][PATCH V3 1/2] bluez4_4.101.bbappend: update according to bluez4

[Anders Darander]

* Cristian Iorga <cristian.iorga@intel.com> [150424 17:45]:

> bluez4 recipe has been updated with proper systemd
> support, so update meta-systemd append accordingly.
> Also update to the right directory structure.

> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
>  .../recipes-connectivity/bluez/bluez4_4.101.bbappend                 | 5 -----
>  1 file changed, 5 deletions(-)
>  rename meta-systemd/{oe-core => meta-oe}/recipes-connectivity/bluez/bluez4_4.101.bbappend (51%)

Like Martin asked on you V2, why do you keep this as a bbappend, instead
of adding this directly to the recipe?

If you look at meta-systemd today, you'll see that there's only a minor
number of recipes from oe-core, that's being appended. All the other
recipes that previously where appended to from meta-systemd, has got
their systemd support directly in their own recipes.

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB / eStorm AB

Re: [meta-oe][meta-systemd][PATCH V3 1/2] bluez4_4.101.bbappend: update according to bluez4

[Paul Eggleton]

Hi Anders,

On Monday 27 April 2015 06:53:19 Anders Darander wrote:
> * Cristian Iorga <cristian.iorga@intel.com> [150424 17:45]:
> > bluez4 recipe has been updated with proper systemd
> > support, so update meta-systemd append accordingly.
> > Also update to the right directory structure.
> > 
> > Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> > ---
> > 
> >  .../recipes-connectivity/bluez/bluez4_4.101.bbappend                 | 5
> >  ----- 1 file changed, 5 deletions(-)
> >  rename meta-systemd/{oe-core =>
> >  meta-oe}/recipes-connectivity/bluez/bluez4_4.101.bbappend (51%)
> Like Martin asked on you V2, why do you keep this as a bbappend, instead
> of adding this directly to the recipe?
> 
> If you look at meta-systemd today, you'll see that there's only a minor
> number of recipes from oe-core, that's being appended. All the other
> recipes that previously where appended to from meta-systemd, has got
> their systemd support directly in their own recipes.

It depends on what you mean by systemd "support". What's left over in most of 
the meta-systemd bbappends is RPROVIDES/RREPLACES/RCONFLICTS on the package 
names which we haven't used for a couple of years by now; surely at some point 
we should let those die with meta-systemd?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [meta-oe][meta-systemd][PATCH V3 1/2] bluez4_4.101.bbappend: update according to bluez4

[Burton, Ross]

On 27 April 2015 at 09:28, Paul Eggleton <paul.eggleton@linux.intel.com>
wrote:

> > If you look at meta-systemd today, you'll see that there's only a minor
> > number of recipes from oe-core, that's being appended. All the other
> > recipes that previously where appended to from meta-systemd, has got
> > their systemd support directly in their own recipes.
>
> It depends on what you mean by systemd "support". What's left over in most
> of
> the meta-systemd bbappends is RPROVIDES/RREPLACES/RCONFLICTS on the package
> names which we haven't used for a couple of years by now; surely at some
> point
> we should let those die with meta-systemd?


FWIW I agree here. Those names are only for compatibility with
meta-systemd, so they can stay in meta-systemd and eventually be retired.

Ross

Re: [meta-oe][meta-systemd][PATCH V3 1/2] bluez4_4.101.bbappend: update according to bluez4

[Martin Jansa]

On Mon, Apr 27, 2015 at 11:54:49AM +0100, Burton, Ross wrote:
> On 27 April 2015 at 09:28, Paul Eggleton <paul.eggleton@linux.intel.com>
> wrote:
> 
> > > If you look at meta-systemd today, you'll see that there's only a minor
> > > number of recipes from oe-core, that's being appended. All the other
> > > recipes that previously where appended to from meta-systemd, has got
> > > their systemd support directly in their own recipes.
> >
> > It depends on what you mean by systemd "support". What's left over in most
> > of
> > the meta-systemd bbappends is RPROVIDES/RREPLACES/RCONFLICTS on the package
> > names which we haven't used for a couple of years by now; surely at some
> > point
> > we should let those die with meta-systemd?
> 
> 
> FWIW I agree here. Those names are only for compatibility with
> meta-systemd, so they can stay in meta-systemd and eventually be retired.

They were already migrated from meta-systemd to meta-openembedded/*
layers long time ago, so now when bluez4 is being added to meta-oe then
for consistency sake it should get these names inside of the recipe as
well.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com