From: Greg KH <gregkh@linuxfoundation.org>
To: Dirk Behme <dirk.behme@gmail.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH for 3.19.y to 3.10.y] net: sysctl_net_core: remove unused variable one
Date: Sun, 26 Apr 2015 09:19:58 +0200 [thread overview]
Message-ID: <20150426071958.GA31992@kroah.com> (raw)
In-Reply-To: <1430032263-5094-1-git-send-email-dirk.behme@gmail.com>
On Sun, Apr 26, 2015 at 09:11:03AM +0200, Dirk Behme wrote:
> Back porting the upstream commit b1cb59cf2efe7 ("net: sysctl_net_core: check
> SNDBUF and RCVBUF for min length") to -stable introduces a compiler warning
>
> net/core/sysctl_net_core.c:26:12: warning: ‘one’ defined but not used [-Wunused-variable]
> static int one = 1;
>
> While upstream has an additional user of the variable 'one' after that commit
> ("tstamp_allow_data"), -stable doesn't have any user of 'one' any more, resulting
> in above compiler warning. Or in other words: -stable doesn't have the
> commit b245be1f4db1a0 ("net-timestamp: no-payload only sysctl") introducing the
> additional user of 'one'.
>
> Fix the compiler warning by removing the unused variable.
No, this was done on purpose, sorry, I can't take this patch. The
network maintainer wants it this way to be easier to backport things.
We can live with the compiler warning.
thanks,
greg k-h
next prev parent reply other threads:[~2015-04-26 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 7:11 [PATCH for 3.19.y to 3.10.y] net: sysctl_net_core: remove unused variable one Dirk Behme
2015-04-26 7:19 ` Greg KH [this message]
2015-04-26 8:09 ` Dirk Behme
2015-04-26 8:41 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150426071958.GA31992@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dirk.behme@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.