All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/ccache: bump to version 3.2.1
Date: Sun, 26 Apr 2015 12:27:55 +0300	[thread overview]
Message-ID: <20150426092755.GJ2258@tarshish> (raw)
In-Reply-To: <1430040062-46308-1-git-send-email-kaszak@gmail.com>

Hi Karoly,
On Sun, Apr 26, 2015 at 11:21:01AM +0200, Karoly Kasza wrote:
> @@ -19,7 +19,7 @@ CCACHE_LICENSE_FILES = LICENSE.txt GPL-3.0.txt
>  # to use HOSTCC_NOCCACHE as the compiler. Instead, we take the easy
>  # path: tell ccache to use its internal copy of zlib, so that ccache
>  # has zero dependency besides the C library.
> -HOST_CCACHE_CONF_OPTS += ccache_cv_zlib_1_2_3=no
> +HOST_CCACHE_CONF_OPTS += --with-bundled-zlib
>  
>  # Patch host-ccache as follows:
>  #  - Use BR_CACHE_DIR instead of CCACHE_DIR, because CCACHE_DIR
> @@ -34,11 +34,11 @@ HOST_CCACHE_CONF_OPTS += ccache_cv_zlib_1_2_3=no
>  #    the need to specify BR_CACHE_DIR when invoking ccache directly.
>  define HOST_CCACHE_PATCH_CONFIGURATION
>  	sed -i 's,getenv("CCACHE_DIR"),getenv("BR_CACHE_DIR"),' $(@D)/ccache.c
> -	sed -i 's,getenv("CCACHE_COMPILERCHECK"),"none",' $(@D)/ccache.c
> -	sed -i 's,"%s/.ccache","$(BR_CACHE_DIR)",' $(@D)/ccache.c
> +	sed -i 's,conf->compiler_check = x_strdup("mtime"),conf->compiler_check = x_strdup("none"),' $(@D)/conf.c
> +	sed -i 's,"%s/.ccache","$(BR_CACHE_DIR)",' $(@D)/conf.c
>  endef

You are doing non trivial changes here and above. Please explain in a commit 
log what you are doing, and why this is needed as part of the version bump.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  parent reply	other threads:[~2015-04-26  9:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-26  9:21 [Buildroot] [PATCH 1/2] package/ccache: bump to version 3.2.1 Karoly Kasza
2015-04-26  9:21 ` [Buildroot] [PATCH 2/2] package/ccache: add wrapper for internal toolchain Karoly Kasza
2015-04-26  9:37   ` Thomas Petazzoni
2015-04-26  9:45     ` Károly Kasza
2015-04-26 12:24       ` Thomas Petazzoni
2015-04-26 12:34         ` Károly Kasza
2015-04-27  8:10           ` Károly Kasza
2015-04-26  9:27 ` Baruch Siach [this message]
2015-04-26  9:38   ` [Buildroot] [PATCH 1/2] package/ccache: bump to version 3.2.1 Károly Kasza
2015-04-26  9:41     ` Baruch Siach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150426092755.GJ2258@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.