All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/ccache: bump to version 3.2.1
Date: Sun, 26 Apr 2015 12:41:57 +0300	[thread overview]
Message-ID: <20150426094157.GK2258@tarshish> (raw)
In-Reply-To: <CABbD_XA_G2=LG8c3zJzbUU=jj0QjkbbnHNTq76n94Ujt6ZukOQ@mail.gmail.com>

Hi K?roly,

On Sun, Apr 26, 2015 at 11:38:52AM +0200, K?roly Kasza wrote:
> > > -     sed -i 's,getenv("CCACHE_COMPILERCHECK"),"none",' $(@D)/ccache.c
> > > -     sed -i 's,"%s/.ccache","$(BR_CACHE_DIR)",' $(@D)/ccache.c
> > > +     sed -i 's,conf->compiler_check =
> > x_strdup("mtime"),conf->compiler_check = x_strdup("none"),' $(@D)/conf.c
> > > +     sed -i 's,"%s/.ccache","$(BR_CACHE_DIR)",' $(@D)/conf.c
> > 
> > You are doing non trivial changes here and above. Please explain in a
> > commit log what you are doing, and why this is needed as part of the 
> > version bump.
> 
> As you probably see, those lines do the exact same as before, just the
> structure of the ccache sources changed with the major version bump. I'll
> wait for some comments on the second patch regarding the introduction of a
> wrapper script and resend with a more informative git log.

Thanks. When doing so please comment also on the _HOOKS change.

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

      reply	other threads:[~2015-04-26  9:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-26  9:21 [Buildroot] [PATCH 1/2] package/ccache: bump to version 3.2.1 Karoly Kasza
2015-04-26  9:21 ` [Buildroot] [PATCH 2/2] package/ccache: add wrapper for internal toolchain Karoly Kasza
2015-04-26  9:37   ` Thomas Petazzoni
2015-04-26  9:45     ` Károly Kasza
2015-04-26 12:24       ` Thomas Petazzoni
2015-04-26 12:34         ` Károly Kasza
2015-04-27  8:10           ` Károly Kasza
2015-04-26  9:27 ` [Buildroot] [PATCH 1/2] package/ccache: bump to version 3.2.1 Baruch Siach
2015-04-26  9:38   ` Károly Kasza
2015-04-26  9:41     ` Baruch Siach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150426094157.GK2258@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.