All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: qemu-trivial@nongnu.org, edgari@xilinx.com,
	qemu-devel@nongnu.org,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH microblaze v1 5/6] mb: cpu: Delete EXCP_NMI
Date: Mon, 27 Apr 2015 19:28:38 +1000	[thread overview]
Message-ID: <20150427092838.GE17116@toto> (raw)
In-Reply-To: <1430075424-25975-6-git-send-email-crosthwaite.peter@gmail.com>

On Sun, Apr 26, 2015 at 12:10:23PM -0700, Peter Crosthwaite wrote:
> This define is unused. Remove.
> 
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>

Hi,

Any reason not to shift down the numbering?

Otherwise the whole series looks good to me.

Thanks,
Edgar


> ---
>  target-microblaze/cpu.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h
> index f21da2f..6522af7 100644
> --- a/target-microblaze/cpu.h
> +++ b/target-microblaze/cpu.h
> @@ -36,7 +36,6 @@ typedef struct CPUMBState CPUMBState;
>  
>  #define ELF_MACHINE	EM_MICROBLAZE
>  
> -#define EXCP_NMI        1
>  #define EXCP_MMU        2
>  #define EXCP_IRQ        3
>  #define EXCP_BREAK      4
> -- 
> 1.9.1
> 
> 


WARNING: multiple messages have this Message-ID (diff)
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: qemu-trivial@nongnu.org, edgari@xilinx.com,
	qemu-devel@nongnu.org,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH microblaze v1 5/6] mb: cpu: Delete EXCP_NMI
Date: Mon, 27 Apr 2015 19:28:38 +1000	[thread overview]
Message-ID: <20150427092838.GE17116@toto> (raw)
In-Reply-To: <1430075424-25975-6-git-send-email-crosthwaite.peter@gmail.com>

On Sun, Apr 26, 2015 at 12:10:23PM -0700, Peter Crosthwaite wrote:
> This define is unused. Remove.
> 
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>

Hi,

Any reason not to shift down the numbering?

Otherwise the whole series looks good to me.

Thanks,
Edgar


> ---
>  target-microblaze/cpu.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h
> index f21da2f..6522af7 100644
> --- a/target-microblaze/cpu.h
> +++ b/target-microblaze/cpu.h
> @@ -36,7 +36,6 @@ typedef struct CPUMBState CPUMBState;
>  
>  #define ELF_MACHINE	EM_MICROBLAZE
>  
> -#define EXCP_NMI        1
>  #define EXCP_MMU        2
>  #define EXCP_IRQ        3
>  #define EXCP_BREAK      4
> -- 
> 1.9.1
> 
> 

  reply	other threads:[~2015-04-27  9:31 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-26 19:10 [Qemu-trivial] [PATCH microblaze v1 0/6] Microblaze Cleanups Peter Crosthwaite
2015-04-26 19:10 ` [Qemu-devel] " Peter Crosthwaite
2015-04-26 19:10 ` [Qemu-trivial] [PATCH microblaze v1 1/6] defconfigs: Piggyback microblazeel on microblaze Peter Crosthwaite
2015-04-26 19:10   ` [Qemu-devel] " Peter Crosthwaite
2015-04-26 19:10 ` [Qemu-trivial] [PATCH microblaze v1 2/6] mb: mmu: Delete flip_um fn prototype Peter Crosthwaite
2015-04-26 19:10   ` [Qemu-devel] " Peter Crosthwaite
2015-04-26 19:10 ` [Qemu-trivial] [PATCH microblaze v1 3/6] mb: cpu: Remote unused cpu_get_pc Peter Crosthwaite
2015-04-26 19:10   ` [Qemu-devel] " Peter Crosthwaite
2015-04-30  8:43   ` [Qemu-trivial] " Alex Bennée
2015-04-30  8:43     ` Alex Bennée
2015-04-26 19:10 ` [Qemu-trivial] [PATCH microblaze v1 4/6] mb: cpu: Remove unused CC_OP enum Peter Crosthwaite
2015-04-26 19:10   ` [Qemu-devel] " Peter Crosthwaite
2015-04-26 19:10 ` [Qemu-trivial] [PATCH microblaze v1 5/6] mb: cpu: Delete EXCP_NMI Peter Crosthwaite
2015-04-26 19:10   ` [Qemu-devel] " Peter Crosthwaite
2015-04-27  9:28   ` Edgar E. Iglesias [this message]
2015-04-27  9:28     ` Edgar E. Iglesias
2015-04-27 13:41     ` [Qemu-trivial] " Michael Tokarev
2015-04-27 13:41       ` [Qemu-devel] " Michael Tokarev
2015-04-27 14:13       ` [Qemu-trivial] " Peter Crosthwaite
2015-04-27 14:13         ` Peter Crosthwaite
2015-04-27 23:25       ` [Qemu-trivial] " Edgar E. Iglesias
2015-04-27 23:25         ` [Qemu-devel] " Edgar E. Iglesias
2015-04-26 19:10 ` [Qemu-trivial] [PATCH microblaze v1 6/6] mb: cpu: delete unused cpu_interrupts_enabled Peter Crosthwaite
2015-04-26 19:10   ` [Qemu-devel] " Peter Crosthwaite
2015-04-27 14:47 ` [Qemu-trivial] [PATCH microblaze v1 0/6] Microblaze Cleanups Michael Tokarev
2015-04-27 14:47   ` [Qemu-devel] " Michael Tokarev
2015-04-29  5:46   ` [Qemu-trivial] " Michael Tokarev
2015-04-29  5:46     ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150427092838.GE17116@toto \
    --to=edgar.iglesias@gmail.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=edgari@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.