All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Fleming <matt@codeblueprint.co.uk>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Matt Fleming
	<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] efi: efivar_create_sysfs_entry() should return negative error codes
Date: Mon, 27 Apr 2015 16:31:25 +0000	[thread overview]
Message-ID: <20150427163125.GD5042@codeblueprint.co.uk> (raw)
In-Reply-To: <20150421092153.GA12098@mwanda>

On Tue, 21 Apr, at 12:21:53PM, Dan Carpenter wrote:
> It's not very normal to return 1 on failure and 0 on success.  There
> isn't a reason for it here, the callers don't care so long as it's
> non-zero on failure.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks, applied.

-- 
Matt Fleming, Intel Open Source Technology Center

WARNING: multiple messages have this Message-ID (diff)
From: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
To: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Matt Fleming
	<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [patch] efi: efivar_create_sysfs_entry() should return negative error codes
Date: Mon, 27 Apr 2015 17:31:25 +0100	[thread overview]
Message-ID: <20150427163125.GD5042@codeblueprint.co.uk> (raw)
In-Reply-To: <20150421092153.GA12098@mwanda>

On Tue, 21 Apr, at 12:21:53PM, Dan Carpenter wrote:
> It's not very normal to return 1 on failure and 0 on success.  There
> isn't a reason for it here, the callers don't care so long as it's
> non-zero on failure.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

Thanks, applied.

-- 
Matt Fleming, Intel Open Source Technology Center

  reply	other threads:[~2015-04-27 16:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21  9:21 [patch] efi: efivar_create_sysfs_entry() should return negative error codes Dan Carpenter
2015-04-21  9:21 ` Dan Carpenter
2015-04-27 16:31 ` Matt Fleming [this message]
2015-04-27 16:31   ` Matt Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150427163125.GD5042@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.