Re: pahole DW_TAG_mutable_type

Re: pahole DW_TAG_mutable_type

[Cody Schafer]

On Mon, Apr 27, 2015 at 12:25 PM, Elliott, Robert (Server Storage)
<Elliott-VXdhtT5mjnY@public.gmane.org> wrote:
>
> Recent versions of libdwarves have removed DW_TAG_mutable_type, which
> affects dwarves_fprintf.c.
>                 http://www.spinics.net/lists/dwarves/msg00121.html
>
> This causes an error building pahole, which has a copy of dwarves_fprintf.c:
>
>
> [  8%] Building C object CMakeFiles/dwarves.dir/dwarves_fprintf.o
> /home/orange/sw/pahole/dwarves_fprintf.c:77:3: error: 'DW_TAG_mutable_type' undeclared here (not in a function)
>   [DW_TAG_mutable_type]    = "mutable_type",
>    ^
> /home/orange/sw/pahole/dwarves_fprintf.c:77:2: error: array index in initializer not of integer type
>   [DW_TAG_mutable_type]    = "mutable_type",
>   ^
> /home/orange/sw/pahole/dwarves_fprintf.c:77:2: error: (near initialization for 'dwarf_tag_names')
> make[2]: *** [CMakeFiles/dwarves.dir/dwarves_fprintf.o] Error 1
>
>
> Deleting that line seems to fix the problem.


I'm not upstream, I'm just some guy with a github repo of pahole :)

Redirecting this to the right mailing list, might already be fixed
upstream (https://git.kernel.org/cgit/devel/pahole/pahole.git), I
haven't checked.

Probably a good idea to add the mailing list (and git url) to the
README to make it more discover-able for folks that find the source
code in other places.
--
To unsubscribe from this list: send the line "unsubscribe dwarves" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: pahole DW_TAG_mutable_type

[Arnaldo Carvalho de Melo]

Em Mon, Apr 27, 2015 at 07:47:02PM -0400, Cody Schafer escreveu:
> On Mon, Apr 27, 2015 at 12:25 PM, Elliott, Robert (Server Storage)
> <Elliott-VXdhtT5mjnY@public.gmane.org> wrote:
> >
> > Recent versions of libdwarves have removed DW_TAG_mutable_type, which
> > affects dwarves_fprintf.c.
> >                 http://www.spinics.net/lists/dwarves/msg00121.html

This line you refer to doesn't remove DW_TAG_mutable_type, it removes a
line that references it.

> > This causes an error building pahole, which has a copy of dwarves_fprintf.c:
> >
> >
> > [  8%] Building C object CMakeFiles/dwarves.dir/dwarves_fprintf.o
> > /home/orange/sw/pahole/dwarves_fprintf.c:77:3: error: 'DW_TAG_mutable_type' undeclared here (not in a function)
> >   [DW_TAG_mutable_type]    = "mutable_type",
> >    ^

Not really, the problem lies elsewhere, i.e. DW_TAG_mutable_type not
being defined, Mark's solution was to just remove the only reference we
had to it, in dwarves_fprintf.c

> > /home/orange/sw/pahole/dwarves_fprintf.c:77:2: error: array index in initializer not of integer type
> >   [DW_TAG_mutable_type]    = "mutable_type",
> >   ^
> > /home/orange/sw/pahole/dwarves_fprintf.c:77:2: error: (near initialization for 'dwarf_tag_names')
> > make[2]: *** [CMakeFiles/dwarves.dir/dwarves_fprintf.o] Error 1
> >
> >
> > Deleting that line seems to fix the problem.

So yes, what you did seems to be what is required.
 
> I'm not upstream, I'm just some guy with a github repo of pahole :)

Are there any outstanding patches in your repo that you think I should
pull?
 
> Redirecting this to the right mailing list, might already be fixed
> upstream (https://git.kernel.org/cgit/devel/pahole/pahole.git), I
> haven't checked.
> 
> Probably a good idea to add the mailing list (and git url) to the
> README to make it more discover-able for folks that find the source
> code in other places.

Right, will try and do this tomorrow, make sure the github repo is in
synch with the kernel.org one, etc.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe dwarves" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: pahole DW_TAG_mutable_type

[Cody Schafer]

> Right, will try and do this tomorrow, make sure the github repo is in
> synch with the kernel.org one, etc.

In case it's not clear, Robert was the originator of that email (which
was initially sent to my github email).

I just forward it to the list and added some suggestions at the end.
--
To unsubscribe from this list: send the line "unsubscribe dwarves" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: pahole DW_TAG_mutable_type

[Elliott, Robert (Server Storage)]

> -----Original Message-----
> From: Cody Schafer [mailto:cody@codyps.com]
> Sent: Monday, April 27, 2015 8:06 PM
> To: Arnaldo Carvalho de Melo
> Cc: Elliott, Robert (Server Storage); dwarves@vger.kernel.org
> Subject: Re: pahole DW_TAG_mutable_type
> 
> > Right, will try and do this tomorrow, make sure the github repo is in
> > synch with the kernel.org one, etc.
> 
> In case it's not clear, Robert was the originator of that email (which
> was initially sent to my github email).
> 
> I just forward it to the list and added some suggestions at the end.

In Google search results, Cody's github site was one above the 
git.kernel.org site (5th place vs. 6th place searching for "pahole").

This may be part of the reason - for the 6th place site it says:
A description for this result is not available because of this 
site's robots.txt – learn more.

Re: pahole DW_TAG_mutable_type

[Arnaldo Carvalho de Melo]

Em Mon, Apr 27, 2015 at 09:06:16PM -0400, Cody Schafer escreveu:
> > Right, will try and do this tomorrow, make sure the github repo is in
> > synch with the kernel.org one, etc.
> 
> In case it's not clear, Robert was the originator of that email (which
> was initially sent to my github email).
> 
> I just forward it to the list and added some suggestions at the end.

I understood that, when I mentioned about making the github repo to
synch with the kernel one I was referring to my github repo for these
tools.

Thanks for the report!

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe dwarves" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html