All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Davydov <vdavydov@parallels.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>, Greg Thelen <gthelen@google.com>,
	Michel Lespinasse <walken@google.com>,
	David Rientjes <rientjes@google.com>,
	Pavel Emelyanov <xemul@parallels.com>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-api@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-mm@kvack.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/3] idle memory tracking
Date: Wed, 29 Apr 2015 10:58:53 +0300	[thread overview]
Message-ID: <20150429075853.GC1694@esperanza> (raw)
In-Reply-To: <20150429035722.GA11486@blaptop>

Hi Minchan,

Thank you for taking a look at this patch set.

On Wed, Apr 29, 2015 at 12:57:22PM +0900, Minchan Kim wrote:
> On Tue, Apr 28, 2015 at 03:24:39PM +0300, Vladimir Davydov wrote:
> >  * /proc/kpageidle.  For each page this file contains a 64-bit number, which
> >    equals 1 if the page is idle or 0 otherwise, indexed by PFN. A page is
> 
> Why do we need 64bit per page to indicate just idle or not?

I don't think we need this, actually. I made this file 64 bit per page
only to conform to other /proc/kpage* files. Currently, I can't think of
any potential use for residual 63 bits, so personally I'm fine with 1
bit per page. If nobody comes with an idea about how > 1 bits could be
used, I'll switch /proc/kpageidle to a bitmask in the next iteration.

Thanks,
Vladimir

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Davydov <vdavydov@parallels.com>
To: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.cz>, Greg Thelen <gthelen@google.com>,
	Michel Lespinasse <walken@google.com>,
	David Rientjes <rientjes@google.com>,
	Pavel Emelyanov <xemul@parallels.com>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	Jonathan Corbet <corbet@lwn.net>, <linux-api@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-mm@kvack.org>,
	<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/3] idle memory tracking
Date: Wed, 29 Apr 2015 10:58:53 +0300	[thread overview]
Message-ID: <20150429075853.GC1694@esperanza> (raw)
In-Reply-To: <20150429035722.GA11486@blaptop>

Hi Minchan,

Thank you for taking a look at this patch set.

On Wed, Apr 29, 2015 at 12:57:22PM +0900, Minchan Kim wrote:
> On Tue, Apr 28, 2015 at 03:24:39PM +0300, Vladimir Davydov wrote:
> >  * /proc/kpageidle.  For each page this file contains a 64-bit number, which
> >    equals 1 if the page is idle or 0 otherwise, indexed by PFN. A page is
> 
> Why do we need 64bit per page to indicate just idle or not?

I don't think we need this, actually. I made this file 64 bit per page
only to conform to other /proc/kpage* files. Currently, I can't think of
any potential use for residual 63 bits, so personally I'm fine with 1
bit per page. If nobody comes with an idea about how > 1 bits could be
used, I'll switch /proc/kpageidle to a bitmask in the next iteration.

Thanks,
Vladimir

  reply	other threads:[~2015-04-29  7:58 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-28 12:24 [PATCH v3 0/3] idle memory tracking Vladimir Davydov
2015-04-28 12:24 ` Vladimir Davydov
2015-04-28 12:24 ` [PATCH v3 1/3] memcg: add page_cgroup_ino helper Vladimir Davydov
2015-04-28 12:24   ` Vladimir Davydov
2015-04-28 12:24 ` [PATCH v3 2/3] proc: add kpagecgroup file Vladimir Davydov
2015-04-28 12:24   ` Vladimir Davydov
2015-04-28 12:24   ` Vladimir Davydov
2015-04-28 12:24 ` [PATCH v3 3/3] proc: add kpageidle file Vladimir Davydov
2015-04-28 12:24   ` Vladimir Davydov
2015-04-29  4:35   ` Minchan Kim
2015-04-29  4:35     ` Minchan Kim
2015-04-29  9:12     ` Vladimir Davydov
2015-04-29  9:12       ` Vladimir Davydov
2015-04-30  8:25       ` Minchan Kim
2015-04-30  8:25         ` Minchan Kim
2015-04-30 14:50         ` Vladimir Davydov
2015-04-30 14:50           ` Vladimir Davydov
2015-04-30 14:50           ` Vladimir Davydov
2015-05-04  3:17           ` Minchan Kim
2015-05-04  3:17             ` Minchan Kim
2015-05-04  9:49             ` Vladimir Davydov
2015-05-04  9:49               ` Vladimir Davydov
2015-05-04  9:49               ` Vladimir Davydov
2015-05-04 10:54               ` Minchan Kim
2015-05-04 10:54                 ` Minchan Kim
2015-05-04 10:54                 ` Minchan Kim
2015-05-08  9:56                 ` Vladimir Davydov
2015-05-08  9:56                   ` Vladimir Davydov
2015-05-08  9:56                   ` Vladimir Davydov
2015-05-09 15:12                   ` Minchan Kim
2015-05-09 15:12                     ` Minchan Kim
2015-05-10 10:34                     ` Vladimir Davydov
2015-05-10 10:34                       ` Vladimir Davydov
2015-05-10 10:34                       ` Vladimir Davydov
2015-05-12  9:41                       ` Vladimir Davydov
2015-05-12  9:41                         ` Vladimir Davydov
     [not found]   ` <4c24a6bf2c9711dd4dbb72a43a16eba6867527b7.1430217477.git.vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2015-04-29  4:57     ` Minchan Kim
2015-04-29  4:57       ` Minchan Kim
2015-04-29  4:57       ` Minchan Kim
2015-04-29  8:31       ` Vladimir Davydov
2015-04-29  8:31         ` Vladimir Davydov
2015-04-29  8:31         ` Vladimir Davydov
2015-04-30  6:55         ` Minchan Kim
2015-04-30  6:55           ` Minchan Kim
2015-04-30  6:55           ` Minchan Kim
2015-04-29  3:57 ` [PATCH v3 0/3] idle memory tracking Minchan Kim
2015-04-29  3:57   ` Minchan Kim
2015-04-29  7:58   ` Vladimir Davydov [this message]
2015-04-29  7:58     ` Vladimir Davydov
     [not found] ` <cover.1430217477.git.vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org>
2015-04-29  5:02   ` Minchan Kim
2015-04-29  5:02     ` Minchan Kim
2015-04-29  5:02     ` Minchan Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150429075853.GC1694@esperanza \
    --to=vdavydov@parallels.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=gorcunov@openvz.org \
    --cc=gthelen@google.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.cz \
    --cc=minchan@kernel.org \
    --cc=rientjes@google.com \
    --cc=walken@google.com \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.