From: baruch@tkos.co.il (Baruch Siach)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: imx: make the imx timer driver implementation independent of SoCs.
Date: Wed, 29 Apr 2015 18:25:27 +0300 [thread overview]
Message-ID: <20150429152527.GH2258@tarshish> (raw)
In-Reply-To: <BL2PR03MB37005C844BCB89007D176F683D70@BL2PR03MB370.namprd03.prod.outlook.com>
Hi Shenwei Wang,
On Wed, Apr 29, 2015 at 03:19:19PM +0000, Shenwei Wang wrote:
> > -----Original Message-----
> > From: Baruch Siach [mailto:baruch at tkos.co.il]
> > Sent: 2015?4?29? 10:08
> > To: Wang Shenwei-B38339
> > Cc: shawn.guo at linaro.org; linux-arm-kernel at lists.infradead.org;
> > devicetree at vger.kernel.org
> > Subject: Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation
> > independent of SoCs.
> >
> > When several SoC share the same IP block the usual convention is to name
> > it in
> > the compatible property string after the first SoC it appeared on. Just look at
> > some binding documentation from Documentation/devicetree/bindings/timer/ to
> > find examples. The allwinner,sun5i-a13-hstimer property is shared by A10s and
> > A13 SoCs. The amlogic,meson6-timer is shared by Meson6 and Meson8 SoCs, and
> > so on.
>
> If the same IP block is shared with several SoCs, why we gave them different compatible
> strings? If no changes in an IP block, I assume no changes in the relating driver as well.
> In this assumption, I don't see any need to introduce a new compatible string for an
> unchanged IP block in a new SoC.
That is exactly what I meant to say. Sorry that I was not clear enough.
When the same IP block is used in a newer generation SoC the same compatible
property string is used. For that reason you can find in sun5i-a10s.dtsi the
line
compatible = "allwinner,sun5i-a13-hstimer";
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: Baruch Siach <baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org>
To: Shenwei Wang <Shenwei.Wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: "shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org"
<shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation independent of SoCs.
Date: Wed, 29 Apr 2015 18:25:27 +0300 [thread overview]
Message-ID: <20150429152527.GH2258@tarshish> (raw)
In-Reply-To: <BL2PR03MB37005C844BCB89007D176F683D70-AZ66ij2kwaY73p3xB2dGY+O6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
Hi Shenwei Wang,
On Wed, Apr 29, 2015 at 03:19:19PM +0000, Shenwei Wang wrote:
> > -----Original Message-----
> > From: Baruch Siach [mailto:baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org]
> > Sent: 2015年4月29日 10:08
> > To: Wang Shenwei-B38339
> > Cc: shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org;
> > devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Subject: Re: [PATCH 1/1] ARM: imx: make the imx timer driver implementation
> > independent of SoCs.
> >
> > When several SoC share the same IP block the usual convention is to name
> > it in
> > the compatible property string after the first SoC it appeared on. Just look at
> > some binding documentation from Documentation/devicetree/bindings/timer/ to
> > find examples. The allwinner,sun5i-a13-hstimer property is shared by A10s and
> > A13 SoCs. The amlogic,meson6-timer is shared by Meson6 and Meson8 SoCs, and
> > so on.
>
> If the same IP block is shared with several SoCs, why we gave them different compatible
> strings? If no changes in an IP block, I assume no changes in the relating driver as well.
> In this assumption, I don't see any need to introduce a new compatible string for an
> unchanged IP block in a new SoC.
That is exactly what I meant to say. Sorry that I was not clear enough.
When the same IP block is used in a newer generation SoC the same compatible
property string is used. For that reason you can find in sun5i-a10s.dtsi the
line
compatible = "allwinner,sun5i-a13-hstimer";
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch-NswTu9S1W3P6gbPvEgmw2w@public.gmane.org - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-04-29 15:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 14:14 [PATCH 1/1] ARM: imx: make the imx timer driver implementation independent of SoCs Shenwei Wang
2015-04-29 14:26 ` Baruch Siach
2015-04-29 14:26 ` Baruch Siach
2015-04-29 14:55 ` Shenwei Wang
2015-04-29 14:55 ` Shenwei Wang
2015-04-29 15:08 ` Baruch Siach
2015-04-29 15:08 ` Baruch Siach
2015-04-29 15:19 ` Shenwei Wang
2015-04-29 15:19 ` Shenwei Wang
2015-04-29 15:25 ` Baruch Siach [this message]
2015-04-29 15:25 ` Baruch Siach
2015-04-29 16:34 ` Shenwei Wang
2015-04-29 16:34 ` Shenwei Wang
2015-04-29 18:57 ` Sascha Hauer
2015-04-29 19:56 ` Shenwei Wang
2015-04-30 5:15 ` Sascha Hauer
2015-04-30 15:16 ` Shenwei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429152527.GH2258@tarshish \
--to=baruch@tkos.co.il \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.