* [PATCH 2/2] Fix variable "error" missing initialization
@ 2015-04-29 16:00 ` Shawn Chang
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Chang @ 2015-04-29 16:00 UTC (permalink / raw)
To: linux-kernel, linux-mm; +Cc: Shawn C
From: Shawn C <citypw@gmail.com>
Signed-off-by: Shawn C <citypw@gmail.com>
---
mm/mlock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/mlock.c b/mm/mlock.c
index c7f6785..660e5c5 100644
--- a/mm/mlock.c
+++ b/mm/mlock.c
@@ -557,7 +557,7 @@ static int do_mlock(unsigned long start, size_t len, int on)
{
unsigned long nstart, end, tmp;
struct vm_area_struct * vma, * prev;
- int error;
+ int error = 0;
VM_BUG_ON(start & ~PAGE_MASK);
VM_BUG_ON(len != PAGE_ALIGN(len));
--
1.9.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] Fix variable "error" missing initialization
@ 2015-04-29 16:00 ` Shawn Chang
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Chang @ 2015-04-29 16:00 UTC (permalink / raw)
To: linux-kernel, linux-mm; +Cc: Shawn C
From: Shawn C <citypw@gmail.com>
Signed-off-by: Shawn C <citypw@gmail.com>
---
mm/mlock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/mlock.c b/mm/mlock.c
index c7f6785..660e5c5 100644
--- a/mm/mlock.c
+++ b/mm/mlock.c
@@ -557,7 +557,7 @@ static int do_mlock(unsigned long start, size_t len, int on)
{
unsigned long nstart, end, tmp;
struct vm_area_struct * vma, * prev;
- int error;
+ int error = 0;
VM_BUG_ON(start & ~PAGE_MASK);
VM_BUG_ON(len != PAGE_ALIGN(len));
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] Fix variable "error" missing initialization
2015-04-29 16:00 ` Shawn Chang
@ 2015-04-29 17:24 ` Mateusz Guzik
-1 siblings, 0 replies; 4+ messages in thread
From: Mateusz Guzik @ 2015-04-29 17:24 UTC (permalink / raw)
To: Shawn Chang; +Cc: linux-kernel, linux-mm
On Thu, Apr 30, 2015 at 12:00:34AM +0800, Shawn Chang wrote:
> From: Shawn C <citypw@gmail.com>
>
> Signed-off-by: Shawn C <citypw@gmail.com>
> ---
> mm/mlock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mlock.c b/mm/mlock.c
> index c7f6785..660e5c5 100644
> --- a/mm/mlock.c
> +++ b/mm/mlock.c
> @@ -557,7 +557,7 @@ static int do_mlock(unsigned long start, size_t len, int on)
> {
> unsigned long nstart, end, tmp;
> struct vm_area_struct * vma, * prev;
> - int error;
> + int error = 0;
>
> VM_BUG_ON(start & ~PAGE_MASK);
> VM_BUG_ON(len != PAGE_ALIGN(len));
> --
> 1.9.1
>
This change does not make sense.
The very first read of error is after it gets set.
I see you sent another patch which credited grsecurity. In their
patchset it makes sense - do_mlock is modified in a way which can
interrupt the loop upcoming loop before it gets the chance to set error.
--
Mateusz Guzik
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] Fix variable "error" missing initialization
@ 2015-04-29 17:24 ` Mateusz Guzik
0 siblings, 0 replies; 4+ messages in thread
From: Mateusz Guzik @ 2015-04-29 17:24 UTC (permalink / raw)
To: Shawn Chang; +Cc: linux-kernel, linux-mm
On Thu, Apr 30, 2015 at 12:00:34AM +0800, Shawn Chang wrote:
> From: Shawn C <citypw@gmail.com>
>
> Signed-off-by: Shawn C <citypw@gmail.com>
> ---
> mm/mlock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/mlock.c b/mm/mlock.c
> index c7f6785..660e5c5 100644
> --- a/mm/mlock.c
> +++ b/mm/mlock.c
> @@ -557,7 +557,7 @@ static int do_mlock(unsigned long start, size_t len, int on)
> {
> unsigned long nstart, end, tmp;
> struct vm_area_struct * vma, * prev;
> - int error;
> + int error = 0;
>
> VM_BUG_ON(start & ~PAGE_MASK);
> VM_BUG_ON(len != PAGE_ALIGN(len));
> --
> 1.9.1
>
This change does not make sense.
The very first read of error is after it gets set.
I see you sent another patch which credited grsecurity. In their
patchset it makes sense - do_mlock is modified in a way which can
interrupt the loop upcoming loop before it gets the chance to set error.
--
Mateusz Guzik
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-29 17:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-29 16:00 [PATCH 2/2] Fix variable "error" missing initialization Shawn Chang
2015-04-29 16:00 ` Shawn Chang
2015-04-29 17:24 ` Mateusz Guzik
2015-04-29 17:24 ` Mateusz Guzik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.