Re: [PATCH v2 2/3] xen/arm: Add p2m_pfn_bits

["Edgar E. Iglesias" <edgar.iglesias@gmail.com>]

On Thu, Apr 30, 2015 at 10:39:19AM +0100, Julien Grall wrote:
> Hi Edgar,
> 
> On 30/04/2015 07:06, Edgar E. Iglesias wrote:
> >      val |= VTCR_T0SZ(0x18); /* 40 bit IPA */
> >      val |= VTCR_SL0(0x1); /* P2M starts at first level */
> >  #else /* CONFIG_ARM_64 */
> >@@ -1557,6 +1561,7 @@ void __init setup_virt_paging(void)
> >
> >      p2m_root_order = pa_range_info[pa_range].root_order;
> >      p2m_root_level = 2 - pa_range_info[pa_range].sl0;
> >+    p2m_pfn_bits = 64 - pa_range_info[pa_range].t0sz;
> 
> You are mixing IPA (Intermediate Physical Address) and PFN (Page
> Frame Number) which have to 2 distinct meaning.
> 
> In this case, we are dealing with IPA. Please rename the variable to
> p2m_ipa_bits and replace PFN by IPA in all the patch.


Oops, yes I'll fix that up and send a new version.

Thanks,
Edgar