All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	linux-mm@kvack.org
Subject: Re: [RFC 07/11] mm: debug: VM_BUG()
Date: Thu, 30 Apr 2015 19:22:01 +0300	[thread overview]
Message-ID: <20150430162201.GC17344@node.dhcp.inet.fi> (raw)
In-Reply-To: <1429044993-1677-8-git-send-email-sasha.levin@oracle.com>

On Tue, Apr 14, 2015 at 04:56:29PM -0400, Sasha Levin wrote:
> VM_BUG() complements VM_BUG_ON() just like with WARN() and WARN_ON().
> 
> This lets us format custom strings to output when a VM_BUG() is hit.
> 
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
>  include/linux/mmdebug.h |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
> index 8b3f5a0..42f41e3 100644
> --- a/include/linux/mmdebug.h
> +++ b/include/linux/mmdebug.h
> @@ -12,7 +12,14 @@ char *format_page(struct page *page, char *buf, char *end);
>  #ifdef CONFIG_DEBUG_VM
>  char *format_vma(const struct vm_area_struct *vma, char *buf, char *end);
>  char *format_mm(const struct mm_struct *mm, char *buf, char *end);
> -#define VM_BUG_ON(cond) BUG_ON(cond)
> +#define VM_BUG(cond, fmt...)						\

vm_bugf() ? ;)

-- 
 Kirill A. Shutemov

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: "Kirill A. Shutemov" <kirill@shutemov.name>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	linux-mm@kvack.org
Subject: Re: [RFC 07/11] mm: debug: VM_BUG()
Date: Thu, 30 Apr 2015 19:22:01 +0300	[thread overview]
Message-ID: <20150430162201.GC17344@node.dhcp.inet.fi> (raw)
In-Reply-To: <1429044993-1677-8-git-send-email-sasha.levin@oracle.com>

On Tue, Apr 14, 2015 at 04:56:29PM -0400, Sasha Levin wrote:
> VM_BUG() complements VM_BUG_ON() just like with WARN() and WARN_ON().
> 
> This lets us format custom strings to output when a VM_BUG() is hit.
> 
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
>  include/linux/mmdebug.h |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/include/linux/mmdebug.h b/include/linux/mmdebug.h
> index 8b3f5a0..42f41e3 100644
> --- a/include/linux/mmdebug.h
> +++ b/include/linux/mmdebug.h
> @@ -12,7 +12,14 @@ char *format_page(struct page *page, char *buf, char *end);
>  #ifdef CONFIG_DEBUG_VM
>  char *format_vma(const struct vm_area_struct *vma, char *buf, char *end);
>  char *format_mm(const struct mm_struct *mm, char *buf, char *end);
> -#define VM_BUG_ON(cond) BUG_ON(cond)
> +#define VM_BUG(cond, fmt...)						\

vm_bugf() ? ;)

-- 
 Kirill A. Shutemov

  reply	other threads:[~2015-04-30 16:22 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-14 20:56 [RFC 00/11] mm: debug: formatting memory management structs Sasha Levin
2015-04-14 20:56 ` Sasha Levin
2015-04-14 20:56 ` [RFC 01/11] mm: debug: format flags in a buffer Sasha Levin
2015-04-14 20:56   ` Sasha Levin
2015-04-30 15:39   ` Kirill A. Shutemov
2015-04-30 15:39     ` Kirill A. Shutemov
2015-04-14 20:56 ` [RFC 02/11] mm: debug: deal with a new family of MM pointers Sasha Levin
2015-04-14 20:56   ` Sasha Levin
2015-04-30 16:17   ` Kirill A. Shutemov
2015-04-30 16:17     ` Kirill A. Shutemov
2015-04-30 16:44     ` Sasha Levin
2015-04-30 16:44       ` Sasha Levin
2015-04-14 20:56 ` [RFC 03/11] mm: debug: dump VMA into a string rather than directly on screen Sasha Levin
2015-04-14 20:56   ` Sasha Levin
2015-04-30 16:18   ` Kirill A. Shutemov
2015-04-30 16:18     ` Kirill A. Shutemov
2015-04-14 20:56 ` [RFC 04/11] mm: debug: dump struct MM " Sasha Levin
2015-04-14 20:56   ` Sasha Levin
2015-04-14 20:56 ` [RFC 05/11] mm: debug: dump page " Sasha Levin
2015-04-14 20:56   ` Sasha Levin
2015-04-14 20:56 ` [RFC 06/11] mm: debug: clean unused code Sasha Levin
2015-04-14 20:56   ` Sasha Levin
2015-04-14 20:56 ` [RFC 07/11] mm: debug: VM_BUG() Sasha Levin
2015-04-14 20:56   ` Sasha Levin
2015-04-30 16:22   ` Kirill A. Shutemov [this message]
2015-04-30 16:22     ` Kirill A. Shutemov
2015-04-14 20:56 ` [RFC 08/11] mm: debug: kill VM_BUG_ON_PAGE Sasha Levin
2015-04-14 20:56   ` Sasha Levin
2015-04-14 20:56 ` [RFC 09/11] mm: debug: kill VM_BUG_ON_VMA Sasha Levin
2015-04-14 20:56   ` Sasha Levin
2015-04-14 20:56 ` [RFC 10/11] mm: debug: kill VM_BUG_ON_MM Sasha Levin
2015-04-14 20:56   ` Sasha Levin
2015-04-14 20:56 ` [RFC 11/11] mm: debug: use VM_BUG() to help with debug output Sasha Levin
2015-04-14 20:56   ` Sasha Levin
2015-04-15  8:45 ` [RFC 00/11] mm: debug: formatting memory management structs Kirill A. Shutemov
2015-04-15  8:45   ` Kirill A. Shutemov
2015-04-15 12:52   ` Sasha Levin
2015-04-15 12:52     ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150430162201.GC17344@node.dhcp.inet.fi \
    --to=kirill@shutemov.name \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sasha.levin@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.