From: Mark Brown <broonie@kernel.org>
To: yang.a.fang@intel.com
Cc: alsa-devel@alsa-project.org, vinod.koul@intel.com,
praveen.k.jain@intel.com, praveen.diwakar@intel.com,
lgirdwood@gmail.com, denny.iriawan@intel.com,
kevin.strasser@linux.intel.com, dgreid@chromium.org
Subject: Re: [PATCH 2/4] ASoC: Intel: Add Cherrytrail & Braswell machine driver cht_bsw_max98090
Date: Thu, 30 Apr 2015 21:19:53 +0100 [thread overview]
Message-ID: <20150430201953.GA543@sirena.org.uk> (raw)
In-Reply-To: <1430358238-74659-2-git-send-email-yang.a.fang@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 836 bytes --]
On Wed, Apr 29, 2015 at 06:43:56PM -0700, yang.a.fang@intel.com wrote:
> From: "Fang, Yang A" <yang.a.fang@intel.com>
>
> Add machine driver for two Intel Cherryview-based platforms, Cherrytrail
> and Braswell, with max98090 codec.
Actually now I think about it one thing here: this isn't a generic
driver for this combination of parts - it's specific to the Chromebook
since it relies on their TI headphone amp/button detect device. This
makes Pierre's concern about documentation even more pressing, and
probably the driver should have an appropriate name.
Of course given that the ACPI ID appears likely to be reused by
non-Chromebooks that have the same Maxim CODEC things might get a bit
fun - I'd suggest trying to find something more Chromebook specific to
match on, or quirking he presence of the TI device.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2015-04-30 20:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 1:43 [PATCH 1/4] ASoC: Intel: Add support max98090 in sst driver yang.a.fang
2015-04-30 1:43 ` [PATCH 2/4] ASoC: Intel: Add Cherrytrail & Braswell machine driver cht_bsw_max98090 yang.a.fang
2015-04-30 4:36 ` Vinod Koul
2015-04-30 6:24 ` Yang Fang
2015-04-30 15:40 ` Pierre-Louis Bossart
2015-04-30 16:39 ` Dylan Reid
2015-04-30 18:30 ` Pierre-Louis Bossart
2015-04-30 17:43 ` Fang, Yang A
2015-05-01 4:44 ` Vinod Koul
2015-04-30 20:15 ` Mark Brown
2015-04-30 20:19 ` Mark Brown [this message]
2015-05-01 18:42 ` [PATCH v2 1/2] ASoC: Intel: Add support max98090 in sst driver yang.a.fang
2015-05-01 18:42 ` [PATCH v2 2/2] ASoC: Intel: Add Cherrytrail & Braswell machine driver cht_bsw_max98090_ti yang.a.fang
2015-05-04 12:17 ` Mark Brown
2015-05-04 14:40 ` Fang, Yang A
2015-05-04 17:14 ` Mark Brown
2015-05-04 12:16 ` [PATCH v2 1/2] ASoC: Intel: Add support max98090 in sst driver Mark Brown
2015-04-30 1:43 ` [PATCH 3/4] ASoC: ts3a227e: add platform data for ts3a227e driver yang.a.fang
2015-04-30 20:02 ` Mark Brown
2015-04-30 20:45 ` Fang, Yang A
2015-04-30 21:25 ` Mark Brown
2015-04-30 1:43 ` [PATCH 4/4] ASoC: ts3a227e: set irq flag base on dmi yang.a.fang
2015-04-30 17:45 ` Dylan Reid
2015-04-30 20:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150430201953.GA543@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=denny.iriawan@intel.com \
--cc=dgreid@chromium.org \
--cc=kevin.strasser@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=praveen.diwakar@intel.com \
--cc=praveen.k.jain@intel.com \
--cc=vinod.koul@intel.com \
--cc=yang.a.fang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.