Re: [PATCH 2/4] ASoC: Intel: Add Cherrytrail & Braswell machine driver cht_bsw_max98090

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 4/30/15 11:39 AM, Dylan Reid wrote:
> On Thu, Apr 30, 2015 at 8:40 AM, Pierre-Louis Bossart
> <pierre-louis.bossart@linux.intel.com> wrote:
>>
>>>>> +       ret = snd_soc_card_jack_new(runtime->card, "Headset Jack",
>>>>> +                               SND_JACK_HEADPHONE | SND_JACK_MICROPHONE
>>>>> |
>>>>> +                               SND_JACK_BTN_0 | SND_JACK_BTN_1 |
>>>>> +                               SND_JACK_BTN_2 | SND_JACK_BTN_3, jack,
>>>>> NULL, 0);
>>>>
>>>> Do you really support all those buttons?
>>>
>>> TI driver supports 4 buttons sound/soc/codecs/ts3a227e.c
>>> google made 4 buttons headsets
>>
>>
>> Not every codec is capable of handling 4 buttons.
>> That TI codec was made specifically to detect 4 different levels of
>> impedance. Looking at the Max98090, I see support for a single button press
>> (change in the status of JKSNS). what makes you think you can handle 4
>> buttons in the codec hardware?
>
> The 98090 isn't involved in the button or jack detection in this case.
> The ts3a227e handles all jack and button events and posts them to the
> jack.

ok, got it. Thanks for the clarification.
Maybe the commit message could be state this dependency, it's not like 
the other machine drivers we've seen so far, there are only 4 lines in 
the patch where this TI chip is mentioned.