From: Marek Vasut <marex@denx.de>
To: Michal Suchanek <hramrach@gmail.com>
Cc: linux-mtd <linux-mtd-bounces@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
"grmoore@altera.com" <grmoore@altera.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
David Woodhouse <dwmw2@infradead.org>,
Rafa?? Mi??ecki <zajec5@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Huang Shijie <b32955@freescale.com>,
linux-sunxi <linux-sunxi@googlegroups.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org, Thomas.Betker@rohde-schwarz.com,
Kumar Gala <galak@codeaurora.org>,
Mark Rutland <mark.rutland@arm.com>,
Brian Norris <computersforpeace@gmail.com>,
Ben Hutchings <ben@decadent.org.uk>,
Alison Chaiken <alison_chaiken@mentor.com>,
"Bean Huo ????????? \(beanhuo\)" <beanhuo@micron.com>
Subject: Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
Date: Thu, 30 Apr 2015 20:34:36 +0200 [thread overview]
Message-ID: <201504302034.36753.marex@denx.de> (raw)
In-Reply-To: <CAOMqctRLnCJfVCYGjsmhORYNk+HCf07wwSXnZv4oqDxbaQqKGw@mail.gmail.com>
On Thursday, April 30, 2015 at 06:56:18 PM, Michal Suchanek wrote:
> On 30 April 2015 at 18:30, <Thomas.Betker@rohde-schwarz.com> wrote:
> > Hello Michal:
> >> I tried to connect a SPI NOR flash to my sunxi board and due to the
> >
> > current
> >
> >> sunxi SPI driver limitations it does not work.
> >>
> >> The SPI driver returns an error when more than 64 bytes are
> >> transferred at once
> >> due to lack of DMA support.
> >
> > Wouldn't it be easier to fix the SPI driver to handle transfers larger
> > than 64 bytes, filling and draining the FIFO multiple times if
> > neccessary? (As far as I can tell, most SPI drivers do this.)
>
> Yes, the intent is to fix this by adding dma support to the driver,
> eventually.
>
> The patch might be still useful for other hardware with developing SPI
> support.
Please just fix the controller driver to correctly handle arbitrary transfer
lengths.
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex-ynQEQJNshbs@public.gmane.org>
To: Michal Suchanek <hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Thomas.Betker-Bf/A/FSCP0w3s4ca2cGeAgC/G2K4zDHf@public.gmane.org,
Alison Chaiken
<alison_chaiken-nmGgyN9QBj3QT0dZR+AlfA@public.gmane.org>,
Huang Shijie <b32955-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
"Bean Huo ????????? (beanhuo)"
<beanhuo-AL4WhLSQfzjQT0dZR+AlfA@public.gmane.org>,
Ben Hutchings <ben-/+tVBieCtBitmTQ+vhA3Yw@public.gmane.org>,
Brian Norris
<computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
David Woodhouse <dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"grmoore-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org"
<grmoore-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-mtd
<linux-mtd-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-sunxi <linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Mika Westerberg
<mika.westerberg-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Rafa?? Mi??ecki <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
Date: Thu, 30 Apr 2015 20:34:36 +0200 [thread overview]
Message-ID: <201504302034.36753.marex@denx.de> (raw)
In-Reply-To: <CAOMqctRLnCJfVCYGjsmhORYNk+HCf07wwSXnZv4oqDxbaQqKGw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thursday, April 30, 2015 at 06:56:18 PM, Michal Suchanek wrote:
> On 30 April 2015 at 18:30, <Thomas.Betker-Bf/A/FSCP0w3s4ca2cGeAgC/G2K4zDHf@public.gmane.org> wrote:
> > Hello Michal:
> >> I tried to connect a SPI NOR flash to my sunxi board and due to the
> >
> > current
> >
> >> sunxi SPI driver limitations it does not work.
> >>
> >> The SPI driver returns an error when more than 64 bytes are
> >> transferred at once
> >> due to lack of DMA support.
> >
> > Wouldn't it be easier to fix the SPI driver to handle transfers larger
> > than 64 bytes, filling and draining the FIFO multiple times if
> > neccessary? (As far as I can tell, most SPI drivers do this.)
>
> Yes, the intent is to fix this by adding dma support to the driver,
> eventually.
>
> The patch might be still useful for other hardware with developing SPI
> support.
Please just fix the controller driver to correctly handle arbitrary transfer
lengths.
Best regards,
Marek Vasut
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marex@denx.de>
To: Michal Suchanek <hramrach@gmail.com>
Cc: Thomas.Betker@rohde-schwarz.com,
Alison Chaiken <alison_chaiken@mentor.com>,
Huang Shijie <b32955@freescale.com>,
"Bean Huo ????????? (beanhuo)" <beanhuo@micron.com>,
Ben Hutchings <ben@decadent.org.uk>,
Brian Norris <computersforpeace@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Kumar Gala <galak@codeaurora.org>,
"grmoore@altera.com" <grmoore@altera.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mtd@lists.infradead.org,
"linux-mtd" <linux-mtd-bounces@lists.infradead.org>,
"linux-sunxi" <linux-sunxi@googlegroups.com>,
Mark Rutland <mark.rutland@arm.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Pawel Moll <pawel.moll@arm.com>, Rob Herring <robh+dt@kernel.org>,
"Rafa?? Mi??ecki" <zajec5@gmail.com>
Subject: Re: [PATCH 0/3] Using SPI NOR flah on sunxi.
Date: Thu, 30 Apr 2015 20:34:36 +0200 [thread overview]
Message-ID: <201504302034.36753.marex@denx.de> (raw)
In-Reply-To: <CAOMqctRLnCJfVCYGjsmhORYNk+HCf07wwSXnZv4oqDxbaQqKGw@mail.gmail.com>
On Thursday, April 30, 2015 at 06:56:18 PM, Michal Suchanek wrote:
> On 30 April 2015 at 18:30, <Thomas.Betker@rohde-schwarz.com> wrote:
> > Hello Michal:
> >> I tried to connect a SPI NOR flash to my sunxi board and due to the
> >
> > current
> >
> >> sunxi SPI driver limitations it does not work.
> >>
> >> The SPI driver returns an error when more than 64 bytes are
> >> transferred at once
> >> due to lack of DMA support.
> >
> > Wouldn't it be easier to fix the SPI driver to handle transfers larger
> > than 64 bytes, filling and draining the FIFO multiple times if
> > neccessary? (As far as I can tell, most SPI drivers do this.)
>
> Yes, the intent is to fix this by adding dma support to the driver,
> eventually.
>
> The patch might be still useful for other hardware with developing SPI
> support.
Please just fix the controller driver to correctly handle arbitrary transfer
lengths.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-04-30 18:34 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 14:22 [PATCH 0/3] Using SPI NOR flah on sunxi Michal Suchanek
2015-04-30 14:22 ` Michal Suchanek
2015-04-30 13:33 ` [PATCH 1/3] MTD: m25p80: fix write return value Michal Suchanek
2015-04-30 13:33 ` Michal Suchanek
2015-04-30 18:43 ` Marek Vasut
2015-04-30 18:43 ` Marek Vasut
2015-04-30 18:43 ` Marek Vasut
2015-04-30 21:37 ` Michal Suchanek
2015-04-30 21:37 ` Michal Suchanek
2015-04-30 21:37 ` Michal Suchanek
2015-04-30 13:38 ` [PATCH 2/3] MTD: spi-nor: check for short writes in spi_nor_write Michal Suchanek
2015-04-30 13:38 ` Michal Suchanek
2015-05-20 23:38 ` Brian Norris
2015-05-20 23:38 ` Brian Norris
2015-05-20 23:38 ` Brian Norris
2015-05-21 8:39 ` Michal Suchanek
2015-05-21 8:39 ` Michal Suchanek
2015-05-21 8:39 ` Michal Suchanek
2015-05-21 10:28 ` Mark Brown
2015-05-21 10:28 ` Mark Brown
2015-05-21 10:28 ` Mark Brown
2015-05-22 7:17 ` Brian Norris
2015-05-22 7:17 ` Brian Norris
2015-05-22 7:17 ` Brian Norris
2015-05-22 7:25 ` Brian Norris
2015-05-22 7:25 ` Brian Norris
2015-05-22 7:25 ` Brian Norris
2015-05-22 9:37 ` Mark Brown
2015-05-22 9:37 ` Mark Brown
2015-05-22 9:37 ` Mark Brown
2015-04-30 13:46 ` [PATCH 3/3] MTD: m25p80: Add option to limit SPI transfer size Michal Suchanek
2015-04-30 13:46 ` Michal Suchanek
2015-04-30 14:58 ` [linux-sunxi] " Julian Calaby
2015-04-30 14:58 ` Julian Calaby
2015-04-30 14:58 ` Julian Calaby
2015-05-20 23:27 ` [linux-sunxi] " Brian Norris
2015-05-20 23:27 ` Brian Norris
2015-05-20 23:27 ` Brian Norris
2015-04-30 16:30 ` [PATCH 0/3] Using SPI NOR flah on sunxi Thomas.Betker
[not found] ` <cover.1430403750.git.hramrach-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-04-30 16:30 ` Thomas.Betker-Bf/A/FSCP0w3s4ca2cGeAgC/G2K4zDHf
2015-04-30 16:30 ` Thomas.Betker
2015-04-30 16:30 ` Thomas.Betker
2015-04-30 16:30 ` Thomas.Betker
2015-04-30 16:56 ` Michal Suchanek
2015-04-30 16:56 ` Michal Suchanek
2015-04-30 16:56 ` Michal Suchanek
2015-04-30 18:34 ` Marek Vasut [this message]
2015-04-30 18:34 ` Marek Vasut
2015-04-30 18:34 ` Marek Vasut
2015-05-20 23:54 ` Brian Norris
2015-05-20 23:54 ` Brian Norris
2015-05-20 23:54 ` Brian Norris
2015-05-20 23:54 ` Brian Norris
2015-04-30 16:30 ` Thomas.Betker
2015-05-01 12:27 ` Stefan Monnier
2015-05-04 10:32 ` [linux-sunxi] " Michal Suchanek
2015-05-04 10:32 ` Michal Suchanek
2015-05-04 10:32 ` Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201504302034.36753.marex@denx.de \
--to=marex@denx.de \
--cc=Thomas.Betker@rohde-schwarz.com \
--cc=alison_chaiken@mentor.com \
--cc=b32955@freescale.com \
--cc=beanhuo@micron.com \
--cc=ben@decadent.org.uk \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=grmoore@altera.com \
--cc=hramrach@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd-bounces@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.